ehealthsolutions/element-x-android
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-android.git synced 2026-11-05 22:00:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

No need to use a dispatcher.

Browse Source 
Fix issue detected by sonar: `Remove this dispatcher. It is pointless when used with only suspending functions.`
This commit is contained in:
Benoit Marty
2023-02-01 15:08:31 +01:00
parent f52b8efa87
commit eafac31ccc
2 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/matrix/src/main/kotlin/io/element/android/libraries/matrix/RustMatrixClient.kt
+1 -1
View File
@@ -87,7 +87,7 @@ internal class RustMatrixClient internal constructor(
.addView(slidingSyncView) .addView(slidingSyncView)
.build() .build()
private val slidingSyncObserverProxy = SlidingSyncObserverProxy(coroutineScope, dispatchers) private val slidingSyncObserverProxy = SlidingSyncObserverProxy(coroutineScope)
private val roomSummaryDataSource: RustRoomSummaryDataSource = private val roomSummaryDataSource: RustRoomSummaryDataSource =
RustRoomSummaryDataSource( RustRoomSummaryDataSource(
slidingSyncObserverProxy.updateSummaryFlow, slidingSyncObserverProxy.updateSummaryFlow,
libraries/matrix/src/main/kotlin/io/element/android/libraries/matrix/sync/SlidingSyncObserverProxy.kt
+2 -4
View File
@@ -16,7 +16,6 @@
package io.element.android.libraries.matrix.sync package io.element.android.libraries.matrix.sync
import io.element.android.libraries.core.coroutine.CoroutineDispatchers
import kotlinx.coroutines.CoroutineScope import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.flow.MutableSharedFlow import kotlinx.coroutines.flow.MutableSharedFlow
import kotlinx.coroutines.flow.SharedFlow import kotlinx.coroutines.flow.SharedFlow
@@ -30,7 +29,6 @@ private const val BUFFER_SIZE = 64
class SlidingSyncObserverProxy( class SlidingSyncObserverProxy(
private val coroutineScope: CoroutineScope, private val coroutineScope: CoroutineScope,
private val coroutineDispatchers: CoroutineDispatchers
) : SlidingSyncObserver { ) : SlidingSyncObserver {
private val updateSummaryMutableFlow = private val updateSummaryMutableFlow =
@@ -39,8 +37,8 @@ class SlidingSyncObserverProxy(
override fun didReceiveSyncUpdate(summary: UpdateSummary) { override fun didReceiveSyncUpdate(summary: UpdateSummary) {
if (summary.rooms.isEmpty()) return if (summary.rooms.isEmpty()) return
coroutineScope.launch(coroutineDispatchers.io) { coroutineScope.launch {
updateSummaryMutableFlow.emit(summary) updateSummaryMutableFlow.tryEmit(summary)
} }
} }
} }