mirror of
https://github.com/Novaloop-AG/element-x-android.git
synced 2026-11-02 21:32:34 +00:00
Fix small code smell (#7058)
* RolesAndPermissionsNode does not need to implement RolesAndPermissionsNavigator and simplify the code. * Remove default implementation in `RoomMemberListNavigator` * Remove dead code. * Fix test compilation issue
This commit is contained in:
+5
-9
@@ -26,12 +26,8 @@ class RolesAndPermissionsNode(
|
||||
@Assisted buildContext: BuildContext,
|
||||
@Assisted plugins: List<Plugin>,
|
||||
private val presenter: RolesAndPermissionsPresenter,
|
||||
) : Node(buildContext, plugins = plugins), RolesAndPermissionsNavigator {
|
||||
) : Node(buildContext, plugins = plugins) {
|
||||
interface Callback : Plugin, RolesAndPermissionsNavigator {
|
||||
override fun openAdminList()
|
||||
override fun openModeratorList()
|
||||
override fun openEditPermissions()
|
||||
|
||||
override fun onBackClick() {}
|
||||
}
|
||||
|
||||
@@ -56,8 +52,8 @@ class RolesAndPermissionsNode(
|
||||
}
|
||||
|
||||
interface RolesAndPermissionsNavigator {
|
||||
fun onBackClick() {}
|
||||
fun openAdminList() {}
|
||||
fun openModeratorList() {}
|
||||
fun openEditPermissions() {}
|
||||
fun onBackClick()
|
||||
fun openAdminList()
|
||||
fun openModeratorList()
|
||||
fun openEditPermissions()
|
||||
}
|
||||
|
||||
+6
-1
@@ -191,7 +191,12 @@ internal fun RolesAndPermissionsViewPreview(@PreviewParameter(RolesAndPermission
|
||||
ElementPreview {
|
||||
RolesAndPermissionsView(
|
||||
state = state,
|
||||
rolesAndPermissionsNavigator = object : RolesAndPermissionsNavigator {},
|
||||
rolesAndPermissionsNavigator = object : RolesAndPermissionsNavigator {
|
||||
override fun onBackClick() {}
|
||||
override fun openAdminList() {}
|
||||
override fun openModeratorList() {}
|
||||
override fun openEditPermissions() {}
|
||||
},
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user