Fix small code smell (#7058)

* RolesAndPermissionsNode does not need to implement RolesAndPermissionsNavigator and simplify the code.

* Remove default implementation in `RoomMemberListNavigator`

* Remove dead code.

* Fix test compilation issue
This commit is contained in:
Benoit Marty
2026-06-19 15:33:01 +02:00
committed by GitHub
parent e370b33771
commit d4aa49f3d3
7 changed files with 20 additions and 37 deletions
@@ -26,12 +26,8 @@ class RolesAndPermissionsNode(
@Assisted buildContext: BuildContext,
@Assisted plugins: List<Plugin>,
private val presenter: RolesAndPermissionsPresenter,
) : Node(buildContext, plugins = plugins), RolesAndPermissionsNavigator {
) : Node(buildContext, plugins = plugins) {
interface Callback : Plugin, RolesAndPermissionsNavigator {
override fun openAdminList()
override fun openModeratorList()
override fun openEditPermissions()
override fun onBackClick() {}
}
@@ -56,8 +52,8 @@ class RolesAndPermissionsNode(
}
interface RolesAndPermissionsNavigator {
fun onBackClick() {}
fun openAdminList() {}
fun openModeratorList() {}
fun openEditPermissions() {}
fun onBackClick()
fun openAdminList()
fun openModeratorList()
fun openEditPermissions()
}
@@ -191,7 +191,12 @@ internal fun RolesAndPermissionsViewPreview(@PreviewParameter(RolesAndPermission
ElementPreview {
RolesAndPermissionsView(
state = state,
rolesAndPermissionsNavigator = object : RolesAndPermissionsNavigator {},
rolesAndPermissionsNavigator = object : RolesAndPermissionsNavigator {
override fun onBackClick() {}
override fun openAdminList() {}
override fun openModeratorList() {}
override fun openEditPermissions() {}
},
)
}
}