Update plugin ktlint to v12.1.0 (#2200)

* Update plugin ktlint to v12.1.0

* Run `./gradlew ktlintFormat` and fix some issues manually.

* Fix other issues reproted by Ktlint

* Limit false positives, KtLint removes unnecessary curly brace in String templates.

* Remove useless Unit

* Minor improvements over ktlint changes

* Restore `AlertDialogContent` behaviour

* Update screenshots

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Benoit Marty <benoit@matrix.org>
Co-authored-by: Jorge Martín <jorgem@element.io>
Co-authored-by: ElementBot <benoitm+elementbot@element.io>

appnav/src/main/kotlin/io/element/android/appnav/BackstackExt.kt

@@ -40,4 +40,3 @@ fun <T : Any> BackStack<T>.removeLast(element: T) {
     } ?: return
     accept(Remove(lastExpectedNavElement.key))
 }
-

appnav/src/main/kotlin/io/element/android/appnav/LoggedInFlowNode.kt

@@ -138,7 +138,7 @@ class LoggedInFlowNode @AssistedInject constructor(
             },
             onStop = {
                 coroutineScope.launch {
-                    //Counterpart startSync is done in observeSyncStateAndNetworkStatus method.
+                    // Counterpart startSync is done in observeSyncStateAndNetworkStatus method.
                     syncService.stopSync()
                 }
             },

appnav/src/main/kotlin/io/element/android/appnav/RootFlowNode.kt

@@ -268,10 +268,9 @@ class RootFlowNode @AssistedInject constructor(
     }
 
     private suspend fun attachSession(sessionId: SessionId): LoggedInAppScopeFlowNode {
-        //TODO handle multi-session
+        // TODO handle multi-session
         return waitForChildAttached { navTarget ->
             navTarget is NavTarget.LoggedInFlow && navTarget.sessionId == sessionId
         }
     }
 }
-

appnav/src/main/kotlin/io/element/android/appnav/di/MatrixClientsHolder.kt

@@ -65,8 +65,9 @@ class MatrixClientsHolder @Inject constructor(private val authenticationService:
     @Suppress("UNCHECKED_CAST")
     fun restoreWithSavedState(state: SavedStateMap?) {
         Timber.d("Restore state")
-        if (state == null || sessionIdsToMatrixClient.isNotEmpty()) return Unit.also {
+        if (state == null || sessionIdsToMatrixClient.isNotEmpty()) {
             Timber.w("Restore with non-empty map")
+            return
         }
         val sessionIds = state[SAVE_INSTANCE_KEY] as? Array<SessionId>
         Timber.d("Restore matrix session keys = ${sessionIds?.map { it.value }}")

appnav/src/main/kotlin/io/element/android/appnav/loggedin/SyncStateView.kt

@@ -59,15 +59,15 @@ fun SyncStateView(
         ) {
             Row(
                 modifier = Modifier
-                        .background(color = ElementTheme.colors.bgSubtleSecondary)
-                        .padding(horizontal = 24.dp, vertical = 10.dp),
+                    .background(color = ElementTheme.colors.bgSubtleSecondary)
+                    .padding(horizontal = 24.dp, vertical = 10.dp),
                 verticalAlignment = Alignment.CenterVertically,
                 horizontalArrangement = Arrangement.spacedBy(10.dp)
             ) {
                 CircularProgressIndicator(
                     modifier = Modifier
-                            .progressSemantics()
-                            .size(12.dp),
+                        .progressSemantics()
+                        .size(12.dp),
                     color = ElementTheme.colors.textPrimary,
                     strokeWidth = 1.5.dp,
                 )

appnav/src/main/kotlin/io/element/android/appnav/room/RoomFlowNode.kt

@@ -136,4 +136,3 @@ class RoomFlowNode @AssistedInject constructor(
         )
     }
 }
-

appnav/src/test/kotlin/io/element/android/appnav/room/LoadingRoomStateFlowFactoryTest.kt

@@ -31,22 +31,22 @@ class LoadingRoomStateFlowFactoryTest {
 
     @Test
     fun `flow should emit Loading and then Loaded when there is a room in cache`() = runTest {
-        val room = FakeMatrixRoom(sessionId= A_SESSION_ID, roomId = A_ROOM_ID)
+        val room = FakeMatrixRoom(sessionId = A_SESSION_ID, roomId = A_ROOM_ID)
         val matrixClient = FakeMatrixClient(A_SESSION_ID).apply {
             givenGetRoomResult(A_ROOM_ID, room)
         }
         val flowFactory = LoadingRoomStateFlowFactory(matrixClient)
         flowFactory
             .create(this, A_ROOM_ID)
-        .test {
-            assertThat(awaitItem()).isEqualTo(LoadingRoomState.Loading)
-            assertThat(awaitItem()).isEqualTo(LoadingRoomState.Loaded(room))
-        }
+            .test {
+                assertThat(awaitItem()).isEqualTo(LoadingRoomState.Loading)
+                assertThat(awaitItem()).isEqualTo(LoadingRoomState.Loaded(room))
+            }
     }
 
     @Test
     fun `flow should emit Loading and then Loaded when there is a room in cache after SS is loaded`() = runTest {
-        val room = FakeMatrixRoom(sessionId= A_SESSION_ID, roomId = A_ROOM_ID)
+        val room = FakeMatrixRoom(sessionId = A_SESSION_ID, roomId = A_ROOM_ID)
         val roomListService = FakeRoomListService()
         val matrixClient = FakeMatrixClient(A_SESSION_ID, roomListService = roomListService)
         val flowFactory = LoadingRoomStateFlowFactory(matrixClient)