ehealthsolutions/element-x-android
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-android.git synced 2026-11-03 06:55:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Comparing mutable state was wrong

Browse Source
This commit is contained in:
Benoit Marty
2025-11-20 16:23:41 +01:00
committed by Benoit Marty
parent 7c6aa0655b
commit c39c4260eb
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
features/rolesandpermissions/impl/src/main/kotlin/io/element/android/features/rolesandpermissions/impl/roles/ChangeRolesPresenter.kt
+1 -2
View File
@@ -134,11 +134,10 @@ class ChangeRolesPresenter(
is ChangeRolesEvent.Save -> { is ChangeRolesEvent.Save -> {
val currentUserIsAdmin = roomInfo.roleOf(room.sessionId) == RoomMember.Role.Admin val currentUserIsAdmin = roomInfo.roleOf(room.sessionId) == RoomMember.Role.Admin
val isModifyingAdmins = role == RoomMember.Role.Admin val isModifyingAdmins = role == RoomMember.Role.Admin
val hasChanges = selectedUsers != usersWithRole
val isConfirming = saveState.value.isConfirming() val isConfirming = saveState.value.isConfirming()
val modifyingOwners = role is RoomMember.Role.Owner val modifyingOwners = role is RoomMember.Role.Owner
val needsConfirmation = (modifyingOwners || currentUserIsAdmin && isModifyingAdmins) && hasChanges && !isConfirming val needsConfirmation = (modifyingOwners || currentUserIsAdmin && isModifyingAdmins) && hasPendingChanges && !isConfirming
when { when {
needsConfirmation -> { needsConfirmation -> {