Merge pull request #7352 from hayaksi1/fix/6189-no-call-in-empty-dm

Do not offer to start a call in a DM with no other member

features/roomcall/impl/src/main/kotlin/io/element/android/features/roomcall/impl/RoomCallStatePresenter.kt

@@ -60,13 +60,16 @@ class RoomCallStatePresenter(
                         isUserLocallyInTheCall = isUserLocallyInTheCall,
                         isAudioCall = roomInfo.activeCallIntentConsensus.isAudio(),
                     )
-                    else -> RoomCallState.StandBy(
+                    else -> {
-                        canStartCall = canJoinCall,
+                        val isEmptyDm = roomInfo.isDm && roomInfo.activeMembersCount <= 1
+                        RoomCallState.StandBy(
+                            canStartCall = canJoinCall && !isEmptyDm,
                             isDM = roomInfo.isDm
                         )
                     }
                 }
             }
+        }
         return callState
     }
 }

features/roomcall/impl/src/test/kotlin/io/element/android/features/roomcall/impl/RoomCallStatePresenterTest.kt

@@ -49,6 +49,42 @@ class RoomCallStatePresenterTest {
         }
     }
 
+    @Test
+    fun `present - a DM with no other member cannot start a call`() = runTest {
+        val room = FakeJoinedRoom(
+            baseRoom = FakeBaseRoom(
+                initialRoomInfo = aRoomInfo(isDm = true, activeMembersCount = 1, joinedMembersCount = 1),
+                roomPermissions = roomPermissions(true),
+            )
+        )
+        val presenter = createRoomCallStatePresenter(joinedRoom = room)
+        presenter.test {
+            skipItems(1)
+            assertThat(awaitItem()).isEqualTo(
+                RoomCallState.StandBy(
+                    canStartCall = false,
+                    isDM = true
+                )
+            )
+        }
+    }
+
+    @Test
+    fun `present - a DM becomes callable once the other member is active`() = runTest {
+        val baseRoom = FakeBaseRoom(
+            initialRoomInfo = aRoomInfo(isDm = true, activeMembersCount = 1, joinedMembersCount = 1),
+            roomPermissions = roomPermissions(true),
+        )
+        val room = FakeJoinedRoom(baseRoom = baseRoom)
+        val presenter = createRoomCallStatePresenter(joinedRoom = room)
+        presenter.test {
+            skipItems(1)
+            assertThat(awaitItem()).isEqualTo(RoomCallState.StandBy(canStartCall = false, isDM = true))
+            baseRoom.givenRoomInfo(aRoomInfo(isDm = true, activeMembersCount = 2, joinedMembersCount = 2))
+            assertThat(awaitItem()).isEqualTo(RoomCallState.StandBy(canStartCall = true, isDM = true))
+        }
+    }
+
     @Test
     fun `present - element call not available`() = runTest {
         val room = FakeJoinedRoom(