ehealthsolutions/element-x-android
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-android.git synced 2026-11-03 06:55:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

QrCodeScanEvents -> QrCodeScanEvent

Browse Source
This commit is contained in:
Benoit Marty
2026-08-25 10:04:23 +02:00
parent 0bf671a305
commit a039fcd655
6 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
features/login/impl/src/main/kotlin/io/element/android/features/login/impl/screens/qrcode/scan/QrCodeScanEvents.kt → features/login/impl/src/main/kotlin/io/element/android/features/login/impl/screens/qrcode/scan/QrCodeScanEvent.kt
+3 -3
View File
@@ -8,7 +8,7 @@
package io.element.android.features.login.impl.screens.qrcode.scan package io.element.android.features.login.impl.screens.qrcode.scan
sealed interface QrCodeScanEvents { sealed interface QrCodeScanEvent {
data class QrCodeScanned(val code: ByteArray) : QrCodeScanEvents data class QrCodeScanned(val code: ByteArray) : QrCodeScanEvent
data object TryAgain : QrCodeScanEvents data object TryAgain : QrCodeScanEvent
} }
features/login/impl/src/main/kotlin/io/element/android/features/login/impl/screens/qrcode/scan/QrCodeScanPresenter.kt
+3 -3
View File
@@ -52,13 +52,13 @@ class QrCodeScanPresenter(
authenticationAction.value = AsyncAction.Failure(it) authenticationAction.value = AsyncAction.Failure(it)
} }
fun handleEvent(event: QrCodeScanEvents) { fun handleEvent(event: QrCodeScanEvent) {
when (event) { when (event) {
QrCodeScanEvents.TryAgain -> { QrCodeScanEvent.TryAgain -> {
isScanning = true isScanning = true
authenticationAction.value = AsyncAction.Uninitialized authenticationAction.value = AsyncAction.Uninitialized
} }
is QrCodeScanEvents.QrCodeScanned -> { is QrCodeScanEvent.QrCodeScanned -> {
isScanning = false isScanning = false
coroutineScope.getQrCodeData(authenticationAction, event.code) coroutineScope.getQrCodeData(authenticationAction, event.code)
} }
features/login/impl/src/main/kotlin/io/element/android/features/login/impl/screens/qrcode/scan/QrCodeScanState.kt
+1 -1
View File
@@ -14,5 +14,5 @@ import io.element.android.libraries.matrix.api.auth.qrlogin.MatrixQrCodeLoginDat
data class QrCodeScanState( data class QrCodeScanState(
val isScanning: Boolean, val isScanning: Boolean,
val authenticationAction: AsyncAction<MatrixQrCodeLoginData>, val authenticationAction: AsyncAction<MatrixQrCodeLoginData>,
val eventSink: (QrCodeScanEvents) -> Unit val eventSink: (QrCodeScanEvent) -> Unit
) )
features/login/impl/src/main/kotlin/io/element/android/features/login/impl/screens/qrcode/scan/QrCodeScanStatePreviewParam.kt
+1 -1
View File
@@ -46,7 +46,7 @@ open class QrCodeScanStatePreviewParam : PreviewParameterProvider<QrCodeScanStat
fun aQrCodeScanState( fun aQrCodeScanState(
isScanning: Boolean = true, isScanning: Boolean = true,
authenticationAction: AsyncAction<MatrixQrCodeLoginData> = AsyncAction.Uninitialized, authenticationAction: AsyncAction<MatrixQrCodeLoginData> = AsyncAction.Uninitialized,
eventSink: (QrCodeScanEvents) -> Unit = {}, eventSink: (QrCodeScanEvent) -> Unit = {},
) = QrCodeScanState( ) = QrCodeScanState(
isScanning = isScanning, isScanning = isScanning,
authenticationAction = authenticationAction, authenticationAction = authenticationAction,
features/login/impl/src/main/kotlin/io/element/android/features/login/impl/screens/qrcode/scan/QrCodeScanView.kt
+2 -2
View File
@@ -105,7 +105,7 @@ private fun Content(
) { ) {
QrCodeCameraView( QrCodeCameraView(
modifier = Modifier.fillMaxSize(), modifier = Modifier.fillMaxSize(),
onScanQrCode = { state.eventSink.invoke(QrCodeScanEvents.QrCodeScanned(it)) }, onScanQrCode = { state.eventSink.invoke(QrCodeScanEvent.QrCodeScanned(it)) },
isScanning = state.isScanning, isScanning = state.isScanning,
) )
} }
@@ -125,7 +125,7 @@ private fun ColumnScope.Buttons(
.fillMaxWidth() .fillMaxWidth()
.padding(bottom = 16.dp), .padding(bottom = 16.dp),
onClick = { onClick = {
state.eventSink.invoke(QrCodeScanEvents.TryAgain) state.eventSink.invoke(QrCodeScanEvent.TryAgain)
} }
) )
Column( Column(
features/login/impl/src/test/kotlin/io/element/android/features/login/impl/screens/qrcode/scan/QrCodeScanPresenterTest.kt
+3 -3
View File
@@ -50,7 +50,7 @@ class QrCodeScanPresenterTest {
) )
presenter.test { presenter.test {
val initialState = awaitItem() val initialState = awaitItem()
initialState.eventSink(QrCodeScanEvents.QrCodeScanned(byteArrayOf())) initialState.eventSink(QrCodeScanEvent.QrCodeScanned(byteArrayOf()))
assertThat(awaitItem().isScanning).isFalse() assertThat(awaitItem().isScanning).isFalse()
assertThat(awaitItem().authenticationAction.isLoading()).isTrue() assertThat(awaitItem().authenticationAction.isLoading()).isTrue()
assertThat(awaitItem().authenticationAction.isSuccess()).isTrue() assertThat(awaitItem().authenticationAction.isSuccess()).isTrue()
@@ -65,14 +65,14 @@ class QrCodeScanPresenterTest {
val presenter = createQrCodeScanPresenter(qrCodeLoginDataFactory = qrCodeLoginDataFactory) val presenter = createQrCodeScanPresenter(qrCodeLoginDataFactory = qrCodeLoginDataFactory)
presenter.test { presenter.test {
val initialState = awaitItem() val initialState = awaitItem()
initialState.eventSink(QrCodeScanEvents.QrCodeScanned(byteArrayOf())) initialState.eventSink(QrCodeScanEvent.QrCodeScanned(byteArrayOf()))
assertThat(awaitItem().isScanning).isFalse() assertThat(awaitItem().isScanning).isFalse()
assertThat(awaitItem().authenticationAction.isLoading()).isTrue() assertThat(awaitItem().authenticationAction.isLoading()).isTrue()
val errorState = awaitItem() val errorState = awaitItem()
assertThat(errorState.authenticationAction.isFailure()).isTrue() assertThat(errorState.authenticationAction.isFailure()).isTrue()
errorState.eventSink(QrCodeScanEvents.TryAgain) errorState.eventSink(QrCodeScanEvent.TryAgain)
assertThat(awaitItem().isScanning).isTrue() assertThat(awaitItem().isScanning).isTrue()
assertThat(awaitItem().authenticationAction.isUninitialized()).isTrue() assertThat(awaitItem().authenticationAction.isUninitialized()).isTrue()
} }