Remove event cache feature flag (#4719)

features/roomlist/impl/src/main/kotlin/io/element/android/features/roomlist/impl/RoomListContextMenu.kt

@@ -193,7 +193,7 @@ private fun RoomListModalBottomSheetContent(
             ),
             style = ListItemStyle.Destructive,
         )
-        if (contextMenu.eventCacheFeatureFlagEnabled) {
+        if (contextMenu.displayClearRoomCacheAction) {
             ListItem(
                 headlineContent = {
                     Text(text = "Clear cache for this room")

features/roomlist/impl/src/main/kotlin/io/element/android/features/roomlist/impl/RoomListPresenter.kt

@@ -264,8 +264,7 @@ class RoomListPresenter @Inject constructor(
             isFavorite = event.roomSummary.isFavorite,
             markAsUnreadFeatureFlagEnabled = featureFlagService.isFeatureEnabled(FeatureFlags.MarkAsUnread),
             hasNewContent = event.roomSummary.hasNewContent,
-            eventCacheFeatureFlagEnabled = appPreferencesStore.isDeveloperModeEnabledFlow().first() &&
+            displayClearRoomCacheAction = appPreferencesStore.isDeveloperModeEnabledFlow().first(),
-                featureFlagService.isFeatureEnabled(FeatureFlags.EventCache),
         )
         contextMenuState.value = initialState
 

features/roomlist/impl/src/main/kotlin/io/element/android/features/roomlist/impl/RoomListState.kt

@@ -51,8 +51,8 @@ data class RoomListState(
             val isDm: Boolean,
             val isFavorite: Boolean,
             val markAsUnreadFeatureFlagEnabled: Boolean,
-            val eventCacheFeatureFlagEnabled: Boolean,
             val hasNewContent: Boolean,
+            val displayClearRoomCacheAction: Boolean,
         ) : ContextMenu
     }
 

features/roomlist/impl/src/main/kotlin/io/element/android/features/roomlist/impl/RoomListStateContextMenuShownProvider.kt

@@ -31,5 +31,5 @@ internal fun aContextMenuShown(
     markAsUnreadFeatureFlagEnabled = true,
     hasNewContent = hasNewContent,
     isFavorite = isFavorite,
-    eventCacheFeatureFlagEnabled = false,
+    displayClearRoomCacheAction = false,
 )

features/roomlist/impl/src/test/kotlin/io/element/android/features/roomlist/impl/RoomListPresenterTest.kt

@@ -297,8 +297,8 @@ class RoomListPresenterTest {
                             isDm = false,
                             isFavorite = false,
                             markAsUnreadFeatureFlagEnabled = true,
-                            eventCacheFeatureFlagEnabled = false,
                             hasNewContent = false,
+                            displayClearRoomCacheAction = false,
                         )
                     )
             }
@@ -315,8 +315,8 @@ class RoomListPresenterTest {
                             isDm = false,
                             isFavorite = true,
                             markAsUnreadFeatureFlagEnabled = true,
-                            eventCacheFeatureFlagEnabled = false,
                             hasNewContent = false,
+                            displayClearRoomCacheAction = false,
                         )
                     )
             }
@@ -344,8 +344,8 @@ class RoomListPresenterTest {
                             isFavorite = false,
                             markAsUnreadFeatureFlagEnabled = true,
                             // true here.
-                            eventCacheFeatureFlagEnabled = true,
                             hasNewContent = false,
+                            displayClearRoomCacheAction = true,
                         )
                     )
             }
@@ -375,8 +375,8 @@ class RoomListPresenterTest {
                         isDm = false,
                         isFavorite = false,
                         markAsUnreadFeatureFlagEnabled = true,
-                        eventCacheFeatureFlagEnabled = false,
                         hasNewContent = false,
+                        displayClearRoomCacheAction = false,
                     )
                 )
 

libraries/featureflag/api/src/main/kotlin/io/element/android/libraries/featureflag/api/FeatureFlags.kt

@@ -147,13 +147,6 @@ enum class FeatureFlags(
         defaultValue = { true },
         isFinished = false,
     ),
-    EventCache(
-        key = "feature.event_cache",
-        title = "Use SDK Event cache",
-        description = "Warning: you must kill and restart the app for the change to take effect.",
-        defaultValue = { true },
-        isFinished = false,
-    ),
     PrintLogsToLogcat(
         key = "feature.print_logs_to_logcat",
         title = "Print logs to logcat",