mirror of
https://github.com/Novaloop-AG/element-x-android.git
synced 2026-11-05 12:54:35 +00:00
Rename function (code review)
This commit is contained in:
@@ -34,7 +34,7 @@ import com.bumble.appyx.navmodel.backstack.BackStack
|
|||||||
import com.bumble.appyx.navmodel.backstack.operation.push
|
import com.bumble.appyx.navmodel.backstack.operation.push
|
||||||
import io.element.android.features.preferences.PreferencesFlowNode
|
import io.element.android.features.preferences.PreferencesFlowNode
|
||||||
import io.element.android.features.roomlist.RoomListNode
|
import io.element.android.features.roomlist.RoomListNode
|
||||||
import io.element.android.libraries.architecture.animation.getDefaultTransitionHandler
|
import io.element.android.libraries.architecture.animation.rememberDefaultTransitionHandler
|
||||||
import io.element.android.libraries.architecture.bindings
|
import io.element.android.libraries.architecture.bindings
|
||||||
import io.element.android.libraries.architecture.createNode
|
import io.element.android.libraries.architecture.createNode
|
||||||
import io.element.android.libraries.di.DaggerComponentOwner
|
import io.element.android.libraries.di.DaggerComponentOwner
|
||||||
@@ -129,7 +129,7 @@ class LoggedInFlowNode(
|
|||||||
navModel = backstack,
|
navModel = backstack,
|
||||||
modifier = modifier,
|
modifier = modifier,
|
||||||
// Animate navigation to settings and to a room
|
// Animate navigation to settings and to a room
|
||||||
transitionHandler = getDefaultTransitionHandler(),
|
transitionHandler = rememberDefaultTransitionHandler(),
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -29,7 +29,7 @@ import com.bumble.appyx.navmodel.backstack.BackStack
|
|||||||
import com.bumble.appyx.navmodel.backstack.operation.push
|
import com.bumble.appyx.navmodel.backstack.operation.push
|
||||||
import io.element.android.features.login.LoginFlowNode
|
import io.element.android.features.login.LoginFlowNode
|
||||||
import io.element.android.features.onboarding.OnBoardingScreen
|
import io.element.android.features.onboarding.OnBoardingScreen
|
||||||
import io.element.android.libraries.architecture.animation.getDefaultTransitionHandler
|
import io.element.android.libraries.architecture.animation.rememberDefaultTransitionHandler
|
||||||
import kotlinx.parcelize.Parcelize
|
import kotlinx.parcelize.Parcelize
|
||||||
import timber.log.Timber
|
import timber.log.Timber
|
||||||
|
|
||||||
@@ -76,7 +76,7 @@ class NotLoggedInFlowNode(
|
|||||||
navModel = backstack,
|
navModel = backstack,
|
||||||
modifier = modifier,
|
modifier = modifier,
|
||||||
// Animate navigation to login screen
|
// Animate navigation to login screen
|
||||||
transitionHandler = getDefaultTransitionHandler(),
|
transitionHandler = rememberDefaultTransitionHandler(),
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -37,7 +37,7 @@ import com.bumble.appyx.navmodel.backstack.operation.newRoot
|
|||||||
import com.bumble.appyx.navmodel.backstack.operation.pop
|
import com.bumble.appyx.navmodel.backstack.operation.pop
|
||||||
import com.bumble.appyx.navmodel.backstack.operation.push
|
import com.bumble.appyx.navmodel.backstack.operation.push
|
||||||
import io.element.android.features.rageshake.bugreport.BugReportNode
|
import io.element.android.features.rageshake.bugreport.BugReportNode
|
||||||
import io.element.android.libraries.architecture.animation.getDefaultTransitionHandler
|
import io.element.android.libraries.architecture.animation.rememberDefaultTransitionHandler
|
||||||
import io.element.android.libraries.architecture.createNode
|
import io.element.android.libraries.architecture.createNode
|
||||||
import io.element.android.libraries.architecture.presenterConnector
|
import io.element.android.libraries.architecture.presenterConnector
|
||||||
import io.element.android.libraries.di.DaggerComponentOwner
|
import io.element.android.libraries.di.DaggerComponentOwner
|
||||||
@@ -114,7 +114,7 @@ class RootFlowNode(
|
|||||||
Children(
|
Children(
|
||||||
navModel = backstack,
|
navModel = backstack,
|
||||||
// Animate opening the bug report screen
|
// Animate opening the bug report screen
|
||||||
transitionHandler = getDefaultTransitionHandler(),
|
transitionHandler = rememberDefaultTransitionHandler(),
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -27,7 +27,7 @@ import com.bumble.appyx.navmodel.backstack.BackStack
|
|||||||
import com.bumble.appyx.navmodel.backstack.operation.push
|
import com.bumble.appyx.navmodel.backstack.operation.push
|
||||||
import io.element.android.features.login.changeserver.ChangeServerNode
|
import io.element.android.features.login.changeserver.ChangeServerNode
|
||||||
import io.element.android.features.login.root.LoginRootNode
|
import io.element.android.features.login.root.LoginRootNode
|
||||||
import io.element.android.libraries.architecture.animation.getDefaultTransitionHandler
|
import io.element.android.libraries.architecture.animation.rememberDefaultTransitionHandler
|
||||||
import io.element.android.libraries.architecture.createNode
|
import io.element.android.libraries.architecture.createNode
|
||||||
import kotlinx.parcelize.Parcelize
|
import kotlinx.parcelize.Parcelize
|
||||||
|
|
||||||
@@ -69,7 +69,7 @@ class LoginFlowNode(
|
|||||||
navModel = backstack,
|
navModel = backstack,
|
||||||
modifier = modifier,
|
modifier = modifier,
|
||||||
// Animate transition to change server screen
|
// Animate transition to change server screen
|
||||||
transitionHandler = getDefaultTransitionHandler(),
|
transitionHandler = rememberDefaultTransitionHandler(),
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
+2
-2
@@ -25,7 +25,7 @@ import com.bumble.appyx.core.node.Node
|
|||||||
import com.bumble.appyx.core.node.ParentNode
|
import com.bumble.appyx.core.node.ParentNode
|
||||||
import com.bumble.appyx.navmodel.backstack.BackStack
|
import com.bumble.appyx.navmodel.backstack.BackStack
|
||||||
import io.element.android.features.preferences.root.PreferencesRootNode
|
import io.element.android.features.preferences.root.PreferencesRootNode
|
||||||
import io.element.android.libraries.architecture.animation.getDefaultTransitionHandler
|
import io.element.android.libraries.architecture.animation.rememberDefaultTransitionHandler
|
||||||
import io.element.android.libraries.architecture.createNode
|
import io.element.android.libraries.architecture.createNode
|
||||||
import kotlinx.parcelize.Parcelize
|
import kotlinx.parcelize.Parcelize
|
||||||
|
|
||||||
@@ -63,7 +63,7 @@ class PreferencesFlowNode(
|
|||||||
Children(
|
Children(
|
||||||
navModel = backstack,
|
navModel = backstack,
|
||||||
modifier = modifier,
|
modifier = modifier,
|
||||||
transitionHandler = getDefaultTransitionHandler()
|
transitionHandler = rememberDefaultTransitionHandler()
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
+1
-1
@@ -24,7 +24,7 @@ import com.bumble.appyx.navmodel.backstack.BackStack
|
|||||||
import com.bumble.appyx.navmodel.backstack.transitionhandler.rememberBackstackSlider
|
import com.bumble.appyx.navmodel.backstack.transitionhandler.rememberBackstackSlider
|
||||||
|
|
||||||
@Composable
|
@Composable
|
||||||
fun <NavTarget> getDefaultTransitionHandler(): ModifierTransitionHandler<NavTarget, BackStack.State> {
|
fun <NavTarget> rememberDefaultTransitionHandler(): ModifierTransitionHandler<NavTarget, BackStack.State> {
|
||||||
return rememberBackstackSlider(
|
return rememberBackstackSlider(
|
||||||
transitionSpec = { spring(stiffness = Spring.StiffnessMediumLow) },
|
transitionSpec = { spring(stiffness = Spring.StiffnessMediumLow) },
|
||||||
)
|
)
|
||||||
|
|||||||
Reference in New Issue
Block a user