change (media preview config) : address review remarks

appnav/src/main/kotlin/io/element/android/appnav/loggedin/MediaPreviewConfigMigration.kt

@@ -52,7 +52,7 @@ class MediaPreviewConfigMigration @Inject constructor(
                 }
             }
             .onFailure {
-                Timber.d("Couldn't perform migration, failed to fetch media preview config.")
+                Timber.e(it, "Couldn't perform migration, failed to fetch media preview config.")
             }
     }
 }

features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/advanced/AdvancedSettingsView.kt

@@ -7,7 +7,6 @@
 
 package io.element.android.features.preferences.impl.advanced
 
-import androidx.compose.foundation.layout.Row
 import androidx.compose.foundation.layout.navigationBarsPadding
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.getValue
@@ -143,12 +142,10 @@ private fun ModerationAndSafety(
             title = stringResource(R.string.screen_advanced_settings_show_media_timeline_title),
             hasDivider = false,
             description = {
-                Row {
+                ListSupportingText(
-                    ListSupportingText(
+                    text = stringResource(R.string.screen_advanced_settings_show_media_timeline_subtitle),
-                        text = stringResource(R.string.screen_advanced_settings_show_media_timeline_subtitle),
+                    contentPadding = ListSupportingTextDefaults.Padding.None,
-                        contentPadding = ListSupportingTextDefaults.Padding.None,
+                )
-                    )
-                }
             }
         )
         ListItem(

features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/advanced/MediaPreviewConfigStateStore.kt

@@ -88,8 +88,9 @@ class DefaultMediaPreviewConfigStateStore @Inject constructor(
 
     override fun setHideInviteAvatars(hide: Boolean) {
         sessionCoroutineScope.launch {
-            Timber.d("Setting hide invite avatars to $hide")
             val prevHideInviteAvatars = hideInviteAvatars.value
+            if (prevHideInviteAvatars == hide) return@launch
+            Timber.d("Setting hide invite avatars to $hide")
             hideInviteAvatars.value = hide
             runUpdatingState(setHideInviteAvatarsAction) {
                 mediaPreviewService
@@ -104,8 +105,9 @@ class DefaultMediaPreviewConfigStateStore @Inject constructor(
 
     override fun setTimelineMediaPreviewValue(value: MediaPreviewValue) {
         sessionCoroutineScope.launch {
-            Timber.d("Setting timeline media preview value to $value")
             val prevTimelineMediaPreviewValue = timelineMediaPreviewValue.value
+            if (prevTimelineMediaPreviewValue == value) return@launch
+            Timber.d("Setting timeline media preview value to $value")
             timelineMediaPreviewValue.value = value
             runUpdatingState(setTimelineMediaPreviewAction) {
                 mediaPreviewService

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/media/RustMediaPreviewService.kt

@@ -56,7 +56,7 @@ class RustMediaPreviewService(
 
 private fun RustMediaPreviewConfig.into(): MediaPreviewConfig {
     return MediaPreviewConfig(
-        mediaPreviewValue = this@into.mediaPreviews.into(),
+        mediaPreviewValue = mediaPreviews.into(),
         hideInviteAvatar = inviteAvatars == InviteAvatars.OFF
     )
 }