ehealthsolutions/element-x-android
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-android.git synced 2026-11-04 20:01:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Try to improve Danger rule for PNGs to ignore screenshots (#234)

Browse Source
This commit is contained in:
Jorge Martin Espinosa
2023-03-20 15:09:50 +01:00
committed by GitHub
parent 73b79cadd0
commit 93a77d94c1
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/danger/dangerfile.js
+3 -1
View File
@@ -107,7 +107,9 @@ if (hasChangedViews) {
} }
// Check for pngs on resources // Check for pngs on resources
const hasPngs = editedFiles.filter(file => file.toLowerCase().endsWith(".png")).length > 0 const hasPngs = editedFiles.filter(file => {
file.toLowerCase().endsWith(".png") && !file.includes("snapshots/images/") // Exclude screenshots
}).length > 0
if (hasPngs) { if (hasPngs) {
warn("You seem to have made changes to some images. Please consider using an vector drawable.") warn("You seem to have made changes to some images. Please consider using an vector drawable.")
} }