Fix the test according to the behavior change.

This commit is contained in:
Benoit Marty
2024-09-04 12:23:52 +02:00
parent 4b7c13dac8
commit 90af83b3ea
@@ -95,7 +95,7 @@ class DefaultUnifiedPushGatewayResolverTest {
} }
@Test @Test
fun `when a custom url is not reachable, the default url is returned`() = runTest { fun `when a custom url is not reachable, the custom url is still returned`() = runTest {
val unifiedPushApiFactory = FakeUnifiedPushApiFactory( val unifiedPushApiFactory = FakeUnifiedPushApiFactory(
discoveryResponse = { throw AN_EXCEPTION } discoveryResponse = { throw AN_EXCEPTION }
) )
@@ -104,7 +104,7 @@ class DefaultUnifiedPushGatewayResolverTest {
) )
val result = sut.getGateway("http://custom.url") val result = sut.getGateway("http://custom.url")
assertThat(unifiedPushApiFactory.baseUrlParameter).isEqualTo("http://custom.url") assertThat(unifiedPushApiFactory.baseUrlParameter).isEqualTo("http://custom.url")
assertThat(result).isEqualTo(UnifiedPushConfig.DEFAULT_PUSH_GATEWAY_HTTP_URL) assertThat(result).isEqualTo("http://custom.url/_matrix/push/v1/notify")
} }
@Test @Test
@@ -121,7 +121,7 @@ class DefaultUnifiedPushGatewayResolverTest {
} }
@Test @Test
fun `when a custom url provides a invalid matrix gateway, the default url is returned`() = runTest { fun `when a custom url provides a invalid matrix gateway, the custom url is still returned`() = runTest {
val unifiedPushApiFactory = FakeUnifiedPushApiFactory( val unifiedPushApiFactory = FakeUnifiedPushApiFactory(
discoveryResponse = invalidDiscoveryResponse discoveryResponse = invalidDiscoveryResponse
) )
@@ -130,7 +130,7 @@ class DefaultUnifiedPushGatewayResolverTest {
) )
val result = sut.getGateway("https://custom.url") val result = sut.getGateway("https://custom.url")
assertThat(unifiedPushApiFactory.baseUrlParameter).isEqualTo("https://custom.url") assertThat(unifiedPushApiFactory.baseUrlParameter).isEqualTo("https://custom.url")
assertThat(result).isEqualTo(UnifiedPushConfig.DEFAULT_PUSH_GATEWAY_HTTP_URL) assertThat(result).isEqualTo("https://custom.url/_matrix/push/v1/notify")
} }
private fun TestScope.createDefaultUnifiedPushGatewayResolver( private fun TestScope.createDefaultUnifiedPushGatewayResolver(