Fix Konsist tests.

This commit is contained in:
Benoit Marty
2026-06-16 14:04:46 +02:00
parent 969880e35a
commit 8e12acf62c
2 changed files with 11 additions and 11 deletions
@@ -16,7 +16,7 @@ import io.element.android.features.lockscreen.impl.biometric.FakeBiometricAuthen
import io.element.android.features.lockscreen.impl.fixtures.aPinCodeManager import io.element.android.features.lockscreen.impl.fixtures.aPinCodeManager
import io.element.android.features.lockscreen.impl.pin.PinCodeManager import io.element.android.features.lockscreen.impl.pin.PinCodeManager
import io.element.android.features.lockscreen.impl.unlock.PinUnlockHelper import io.element.android.features.lockscreen.impl.unlock.PinUnlockHelper
import io.element.android.features.lockscreen.test.FakeDeviceUnlockCallback import io.element.android.features.lockscreen.test.FakeDeviceUnlockEntryPointCallback
import io.element.android.tests.testutils.lambda.lambdaRecorder import io.element.android.tests.testutils.lambda.lambdaRecorder
import io.element.android.tests.testutils.test import io.element.android.tests.testutils.test
import kotlinx.coroutines.ExperimentalCoroutinesApi import kotlinx.coroutines.ExperimentalCoroutinesApi
@@ -40,9 +40,9 @@ class DeviceUnlockPresenterTest {
createBiometricAuthenticator = { fakeBiometricAuthenticator }, createBiometricAuthenticator = { fakeBiometricAuthenticator },
) )
val callbackHolder = DeviceUnlockCallbackHolder() val callbackHolder = DeviceUnlockCallbackHolder()
val callback = FakeDeviceUnlockCallback() val callback = FakeDeviceUnlockEntryPointCallback()
createPresenter( createDeviceUnlockPresenter(
biometricAuthenticatorManager = biometricAuthenticatorManager, biometricAuthenticatorManager = biometricAuthenticatorManager,
callbackHolder = callbackHolder, callbackHolder = callbackHolder,
).test { ).test {
@@ -60,11 +60,11 @@ class DeviceUnlockPresenterTest {
@Test @Test
fun `present - when unlock requested and device unlock unavailable and app pin is configured, show app pin`() = runTest { fun `present - when unlock requested and device unlock unavailable and app pin is configured, show app pin`() = runTest {
val callbackHolder = DeviceUnlockCallbackHolder() val callbackHolder = DeviceUnlockCallbackHolder()
val callback = FakeDeviceUnlockCallback() val callback = FakeDeviceUnlockEntryPointCallback()
val pinCodeManager = aPinCodeManager().apply { val pinCodeManager = aPinCodeManager().apply {
createPinCode("1234") createPinCode("1234")
} }
createPresenter( createDeviceUnlockPresenter(
biometricAuthenticatorManager = FakeBiometricAuthenticatorManager(canUseDeviceUnlock = false), biometricAuthenticatorManager = FakeBiometricAuthenticatorManager(canUseDeviceUnlock = false),
callbackHolder = callbackHolder, callbackHolder = callbackHolder,
pinCodeManager = pinCodeManager, pinCodeManager = pinCodeManager,
@@ -85,10 +85,10 @@ class DeviceUnlockPresenterTest {
fun `present - when unlock requested and no security, unlock immediately`() = runTest { fun `present - when unlock requested and no security, unlock immediately`() = runTest {
val callbackHolder = DeviceUnlockCallbackHolder() val callbackHolder = DeviceUnlockCallbackHolder()
val onUnlockedLambda = lambdaRecorder<Unit> { } val onUnlockedLambda = lambdaRecorder<Unit> { }
val callback = FakeDeviceUnlockCallback( val callback = FakeDeviceUnlockEntryPointCallback(
onUnlockedLambda = onUnlockedLambda, onUnlockedLambda = onUnlockedLambda,
) )
createPresenter( createDeviceUnlockPresenter(
biometricAuthenticatorManager = FakeBiometricAuthenticatorManager(canUseDeviceUnlock = false), biometricAuthenticatorManager = FakeBiometricAuthenticatorManager(canUseDeviceUnlock = false),
callbackHolder = callbackHolder, callbackHolder = callbackHolder,
).test { ).test {
@@ -106,13 +106,13 @@ class DeviceUnlockPresenterTest {
fun `present - CancelPinCode event cancels unlock request`() = runTest { fun `present - CancelPinCode event cancels unlock request`() = runTest {
val callbackHolder = DeviceUnlockCallbackHolder() val callbackHolder = DeviceUnlockCallbackHolder()
val onCancelLambda = lambdaRecorder<Unit> { } val onCancelLambda = lambdaRecorder<Unit> { }
val callback = FakeDeviceUnlockCallback( val callback = FakeDeviceUnlockEntryPointCallback(
onCancelLambda = onCancelLambda, onCancelLambda = onCancelLambda,
) )
val pinCodeManager = aPinCodeManager().apply { val pinCodeManager = aPinCodeManager().apply {
createPinCode("1234") createPinCode("1234")
} }
createPresenter( createDeviceUnlockPresenter(
biometricAuthenticatorManager = FakeBiometricAuthenticatorManager(canUseDeviceUnlock = false), biometricAuthenticatorManager = FakeBiometricAuthenticatorManager(canUseDeviceUnlock = false),
callbackHolder = callbackHolder, callbackHolder = callbackHolder,
pinCodeManager = pinCodeManager, pinCodeManager = pinCodeManager,
@@ -133,7 +133,7 @@ class DeviceUnlockPresenterTest {
} }
} }
private fun createPresenter( private fun createDeviceUnlockPresenter(
biometricAuthenticatorManager: FakeBiometricAuthenticatorManager = FakeBiometricAuthenticatorManager(), biometricAuthenticatorManager: FakeBiometricAuthenticatorManager = FakeBiometricAuthenticatorManager(),
callbackHolder: DeviceUnlockCallbackHolder = DeviceUnlockCallbackHolder(), callbackHolder: DeviceUnlockCallbackHolder = DeviceUnlockCallbackHolder(),
pinCodeManager: PinCodeManager = aPinCodeManager(), pinCodeManager: PinCodeManager = aPinCodeManager(),
@@ -10,7 +10,7 @@ package io.element.android.features.lockscreen.test
import io.element.android.features.lockscreen.api.DeviceUnlockEntryPoint import io.element.android.features.lockscreen.api.DeviceUnlockEntryPoint
import io.element.android.tests.testutils.EnsureNeverCalled import io.element.android.tests.testutils.EnsureNeverCalled
class FakeDeviceUnlockCallback( class FakeDeviceUnlockEntryPointCallback(
private val onCancelLambda: () -> Unit = EnsureNeverCalled(), private val onCancelLambda: () -> Unit = EnsureNeverCalled(),
private val onUnlockedLambda: () -> Unit = EnsureNeverCalled(), private val onUnlockedLambda: () -> Unit = EnsureNeverCalled(),
) : DeviceUnlockEntryPoint.Callback { ) : DeviceUnlockEntryPoint.Callback {