ehealthsolutions/element-x-android
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-android.git synced 2026-11-03 06:55:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make sure we don't upload any user ids in tags either

Browse Source
This commit is contained in:
Jorge Martín
2025-12-17 13:09:23 +01:00
committed by Jorge Martin Espinosa
parent 425a694564
commit 7864066f9a
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/analyticsproviders/sentry/src/main/kotlin/io/element/android/services/analyticsproviders/sentry/SentryAnalyticsProvider.kt
+7 -3
View File
@@ -118,11 +118,15 @@ class SentryAnalyticsProvider(
@VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
internal fun prepareTransactionBeforeSend(transaction: SentryTransaction): SentryTransaction { internal fun prepareTransactionBeforeSend(transaction: SentryTransaction): SentryTransaction {
// Ensure we'll never upload any session ids // Ensure we'll never upload any session ids in extras or tags
val possibleSessionIds = transaction.extras?.filter { (it.value as? String)?.startsWith("@") == true }.orEmpty() val invalidExtras = transaction.extras?.filter { (it.value as? String)?.startsWith("@") == true }.orEmpty()
for (invalidExtra in possibleSessionIds) { for (invalidExtra in invalidExtras) {
transaction.removeExtra(invalidExtra.key) transaction.removeExtra(invalidExtra.key)
} }
val invalidTags = transaction.tags?.filter { it.value.startsWith("@") }.orEmpty()
for (invalidTag in invalidExtras) {
transaction.removeTag(invalidTag.key)
}
val sessionId = appNavigationStateService.appNavigationState.value.navigationState.currentSessionId() val sessionId = appNavigationStateService.appNavigationState.value.navigationState.currentSessionId()
if (sessionId != null) { if (sessionId != null) {