ehealthsolutions/element-x-android
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-android.git synced 2026-11-05 12:54:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix infinite recomposition when on top of the timeline.

Browse Source
This commit is contained in:
Benoit Marty
2023-07-03 13:32:59 +02:00
committed by Benoit Marty
parent d66d28db72
commit 76e4c684d0
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/TimelineView.kt
+7 -4
View File
@@ -233,12 +233,9 @@ internal fun BoxScope.TimelineScrollHelper(
val isScrollFinished by remember { derivedStateOf { !lazyListState.isScrollInProgress } } val isScrollFinished by remember { derivedStateOf { !lazyListState.isScrollInProgress } }
val shouldAutoScrollToBottom by remember { derivedStateOf { lazyListState.firstVisibleItemIndex < 2 } } val shouldAutoScrollToBottom by remember { derivedStateOf { lazyListState.firstVisibleItemIndex < 2 } }
LaunchedEffect(timelineItems, firstVisibleItemIndex, isScrollFinished) { LaunchedEffect(timelineItems, firstVisibleItemIndex) {
if (!isScrollFinished) return@LaunchedEffect if (!isScrollFinished) return@LaunchedEffect
// Notify the parent composable about the first visible item index when scrolling finishes
onScrollFinishedAt(firstVisibleItemIndex)
// Auto-scroll when new timeline items appear // Auto-scroll when new timeline items appear
if (shouldAutoScrollToBottom) { if (shouldAutoScrollToBottom) {
coroutineScope.launch { coroutineScope.launch {
@@ -246,6 +243,12 @@ internal fun BoxScope.TimelineScrollHelper(
} }
} }
} }
LaunchedEffect(isScrollFinished) {
if (!isScrollFinished) return@LaunchedEffect
// Notify the parent composable about the first visible item index when scrolling finishes
onScrollFinishedAt(firstVisibleItemIndex)
}
// Jump to bottom button (display also in previews) // Jump to bottom button (display also in previews)
if (!shouldAutoScrollToBottom || LocalInspectionMode.current) { if (!shouldAutoScrollToBottom || LocalInspectionMode.current) {