Message queuing : use redactEvent on timeline instead of room.

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesPresenter.kt

@@ -304,11 +304,9 @@ class MessagesPresenter @AssistedInject constructor(
     }
 
     private suspend fun handleActionRedact(event: TimelineItem.Event) {
-        if (event.failedToSend) {
+        timelineController.invokeOnCurrentTimeline {
-            // If the message hasn't been sent yet, just cancel it
+            redactEvent(eventId = event.eventId, transactionId = event.transactionId, reason = null)
-            event.transactionId?.let { room.cancelSend(it) }
+                .onFailure { Timber.e(it) }
-        } else if (event.eventId != null) {
-            room.redactEvent(event.eventId)
         }
     }
 

features/poll/impl/src/main/kotlin/io/element/android/features/poll/impl/data/PollRepository.kt

@@ -68,8 +68,12 @@ class PollRepository @Inject constructor(
 
     suspend fun deletePoll(
         pollStartId: EventId,
-    ): Result<Unit> =
+    ): Result<Boolean> =
-        room.redactEvent(
+        timelineProvider
-            eventId = pollStartId,
+            .getActiveTimeline()
-        )
+            .redactEvent(
+                eventId = pollStartId,
+                transactionId = null,
+                reason = null,
+            )
 }

libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/room/MatrixRoom.kt

@@ -130,8 +130,6 @@ interface MatrixRoom : Closeable {
 
     suspend fun sendMessage(body: String, htmlBody: String?, mentions: List<Mention>): Result<Unit>
 
-    suspend fun redactEvent(eventId: EventId, reason: String? = null): Result<Unit>
-
     suspend fun sendImage(
         file: File,
         thumbnailFile: File?,

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustMatrixRoom.kt

@@ -324,12 +324,6 @@ class RustMatrixRoom(
         return liveTimeline.sendMessage(body, htmlBody, mentions)
     }
 
-    override suspend fun redactEvent(eventId: EventId, reason: String?) = withContext(roomDispatcher) {
-        runCatching {
-            innerRoom.redact(eventId.value, reason)
-        }
-    }
-
     override suspend fun leave(): Result<Unit> = withContext(roomDispatcher) {
         runCatching {
             innerRoom.leave()

libraries/matrix/test/src/main/kotlin/io/element/android/libraries/matrix/test/room/FakeMatrixRoom.kt

@@ -112,7 +112,7 @@ class FakeMatrixRoom(
     private var updateUserRoleResult = Result.success(Unit)
     private var toggleReactionResult = Result.success(Unit)
     private var retrySendMessageResult = Result.success(Unit)
-    private var cancelSendResult = Result.success(Unit)
+    private var cancelSendResult = Result.success(true)
     private var forwardEventResult = Result.success(Unit)
     private var reportContentResult = Result.success(Unit)
     private var kickUserResult = Result.success(Unit)
@@ -281,7 +281,7 @@ class FakeMatrixRoom(
         return retrySendMessageResult
     }
 
-    override suspend fun cancelSend(transactionId: TransactionId): Result<Unit> {
+    override suspend fun cancelSend(transactionId: TransactionId): Result<Boolean> {
         cancelSendCount++
         return cancelSendResult
     }
@@ -294,14 +294,6 @@ class FakeMatrixRoom(
         return eventPermalinkResult(eventId)
     }
 
-    var redactEventEventIdParam: EventId? = null
-        private set
-
-    override suspend fun redactEvent(eventId: EventId, reason: String?): Result<Unit> {
-        redactEventEventIdParam = eventId
-        return Result.success(Unit)
-    }
-
     override suspend fun leave(): Result<Unit> {
         return leaveRoomLambda()
     }
@@ -626,7 +618,7 @@ class FakeMatrixRoom(
         retrySendMessageResult = result
     }
 
-    fun givenCancelSendResult(result: Result<Unit>) {
+    fun givenCancelSendResult(result: Result<Boolean>) {
         cancelSendResult = result
     }