quality: fix more tests

features/rolesandpermissions/impl/src/main/kotlin/io/element/android/features/rolesandpermissions/impl/roles/ChangeRolesPresenter.kt

@@ -104,7 +104,6 @@ class ChangeRolesPresenter(
 
         val roomInfo by room.roomInfoFlow.collectAsState()
         fun canChangeMemberRole(userId: UserId): Boolean {
-            // This is used to group the
             val currentUserRole = roomInfo.roleOf(room.sessionId)
             val otherUserRole = roomInfo.roleOf(userId)
             return currentUserRole.powerLevel > otherUserRole.powerLevel

features/rolesandpermissions/impl/src/test/kotlin/io/element/android/features/rolesandpermissions/impl/roles/ChangeRolesPresenterTest.kt

@@ -351,21 +351,15 @@ class ChangeRolesPresenterTest {
         moleculeFlow(RecompositionMode.Immediate) {
             presenter.present()
         }.test {
-            skipItems(1)
+            skipItems(2)
             val initialState = awaitItem()
             assertThat(initialState.selectedUsers).hasSize(1)
-
             initialState.eventSink(ChangeRolesEvent.UserSelectionToggled(MatrixUser(A_USER_ID_2)))
             awaitItem().eventSink(ChangeRolesEvent.Save)
             val confirmingState = awaitItem()
             assertThat(confirmingState.savingState).isEqualTo(AsyncAction.ConfirmingNoParams)
-
             confirmingState.eventSink(ChangeRolesEvent.Save)
-
+            assertThat(awaitItem().savingState).isInstanceOf(AsyncAction.Loading::class.java)
-            val loadingState = awaitItem()
-            assertThat(loadingState.savingState).isInstanceOf(AsyncAction.Loading::class.java)
-            skipItems(1)
-
             assertThat(awaitItem().savingState).isEqualTo(AsyncAction.Success(true))
         }
     }
@@ -413,18 +407,12 @@ class ChangeRolesPresenterTest {
         moleculeFlow(RecompositionMode.Immediate) {
             presenter.present()
         }.test {
-            skipItems(1)
+            skipItems(2)
             val initialState = awaitItem()
             assertThat(initialState.selectedUsers).hasSize(1)
-
             initialState.eventSink(ChangeRolesEvent.UserSelectionToggled(MatrixUser(A_USER_ID_2)))
-
             awaitItem().eventSink(ChangeRolesEvent.Save)
-
+            assertThat(awaitItem().savingState).isInstanceOf(AsyncAction.Loading::class.java)
-            val loadingState = awaitItem()
-            assertThat(loadingState.savingState).isInstanceOf(AsyncAction.Loading::class.java)
-            skipItems(1)
-
             assertThat(awaitItem().savingState).isEqualTo(AsyncAction.Success(true))
             assertThat(analyticsService.capturedEvents.last()).isEqualTo(RoomModeration(RoomModeration.Action.ChangeMemberRole, RoomModeration.Role.Moderator))
         }
@@ -491,7 +479,7 @@ class ChangeRolesPresenterTest {
         moleculeFlow(RecompositionMode.Immediate) {
             presenter.present()
         }.test {
-            skipItems(1)
+            skipItems(2)
             val initialState = awaitItem()
             assertThat(initialState.selectedUsers).hasSize(1)
 
@@ -501,8 +489,6 @@ class ChangeRolesPresenterTest {
 
             val loadingState = awaitItem()
             assertThat(loadingState.savingState).isInstanceOf(AsyncAction.Loading::class.java)
-            skipItems(1)
-
             assertThat(awaitItem().savingState).isEqualTo(AsyncAction.Success(true))
             assertThat(analyticsService.capturedEvents.last()).isEqualTo(RoomModeration(RoomModeration.Action.ChangeMemberRole, RoomModeration.Role.User))
         }
@@ -520,7 +506,7 @@ class ChangeRolesPresenterTest {
         moleculeFlow(RecompositionMode.Immediate) {
             presenter.present()
         }.test {
-            skipItems(1)
+            skipItems(2)
             val initialState = awaitItem()
             assertThat(initialState.selectedUsers).hasSize(1)
 
@@ -529,7 +515,6 @@ class ChangeRolesPresenterTest {
             awaitItem().eventSink(ChangeRolesEvent.Save)
             val loadingState = awaitItem()
             assertThat(loadingState.savingState).isInstanceOf(AsyncAction.Loading::class.java)
-            skipItems(1)
             val failedState = awaitItem()
             assertThat(failedState.savingState).isInstanceOf(AsyncAction.Failure::class.java)
 
@@ -567,5 +552,6 @@ internal fun TestScope.createChangeRolesPresenter(
         room = room,
         dispatchers = dispatchers,
         analyticsService = analyticsService,
+        roomCoroutineScope = this,
     )
 }

features/rolesandpermissions/test/src/main/kotlin/io/element/android/features/changeroommemberroles/test/FakeRolesAndPermissionsEntryPoint.kt

@@ -0,0 +1,19 @@
+/*
+ * Copyright 2025 New Vector Ltd.
+ *
+ * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
+ * Please see LICENSE files in the repository root for full details.
+ */
+
+package io.element.android.features.changeroommemberroles.test
+
+import com.bumble.appyx.core.modality.BuildContext
+import com.bumble.appyx.core.node.Node
+import io.element.android.features.rolesandpermissions.api.RolesAndPermissionsEntryPoint
+import io.element.android.tests.testutils.lambda.lambdaError
+
+class FakeRolesAndPermissionsEntryPoint : RolesAndPermissionsEntryPoint {
+    override fun createNode(parentNode: Node, buildContext: BuildContext): Node {
+        lambdaError()
+    }
+}

features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/impl/DefaultRoomDetailsEntryPointTest.kt

@@ -13,6 +13,7 @@ import com.bumble.appyx.testing.junit4.util.MainDispatcherRule
 import com.google.common.truth.Truth.assertThat
 import io.element.android.features.call.test.FakeElementCallEntryPoint
 import io.element.android.features.changeroommemberroles.test.FakeChangeRoomMemberRolesEntryPoint
+import io.element.android.features.changeroommemberroles.test.FakeRolesAndPermissionsEntryPoint
 import io.element.android.features.knockrequests.test.FakeKnockRequestsListEntryPoint
 import io.element.android.features.messages.test.FakeMessagesEntryPoint
 import io.element.android.features.poll.test.history.FakePollHistoryEntryPoint
@@ -58,6 +59,7 @@ class DefaultRoomDetailsEntryPointTest {
                 outgoingVerificationEntryPoint = FakeOutgoingVerificationEntryPoint(),
                 reportRoomEntryPoint = FakeReportRoomEntryPoint(),
                 changeRoomMemberRolesEntryPoint = FakeChangeRoomMemberRolesEntryPoint(),
+                rolesAndPermissionsEntryPoint = FakeRolesAndPermissionsEntryPoint(),
             )
         }
         val callback = object : RoomDetailsEntryPoint.Callback {