From 69a1870f58a952c6e78ddcbbdf0087348e30a361 Mon Sep 17 00:00:00 2001
From: ganfra <francoisg@element.io>
Date: Tue, 29 Sep 2026 16:35:33 +0200
Subject: [PATCH] Use existing strings

---
 .../messages/impl/timeline/TimelinePresenter.kt   |  3 ++-
 .../messages/impl/topbars/SelectionModeTopBar.kt  |  3 ++-
 .../impl/src/main/res/values/temporary.xml        | 15 ---------------
 3 files changed, 4 insertions(+), 17 deletions(-)
 delete mode 100644 features/messages/impl/src/main/res/values/temporary.xml

diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/TimelinePresenter.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/TimelinePresenter.kt
index 320e362024..a712e47cba 100644
--- a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/TimelinePresenter.kt
+++ b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/TimelinePresenter.kt
@@ -63,6 +63,7 @@ import io.element.android.libraries.matrix.api.timeline.Timeline
 import io.element.android.libraries.matrix.api.timeline.item.event.LocalEventSendState
 import io.element.android.libraries.matrix.api.timeline.item.event.TimelineItemEventOrigin
 import io.element.android.libraries.preferences.api.store.SessionPreferencesStore
+import io.element.android.libraries.ui.strings.CommonStrings
 import io.element.android.services.analytics.api.AnalyticsLongRunningTransaction.DisplayFirstTimelineItems
 import io.element.android.services.analytics.api.AnalyticsLongRunningTransaction.NotificationToMessage
 import io.element.android.services.analytics.api.AnalyticsLongRunningTransaction.OpenRoom
@@ -275,7 +276,7 @@ class TimelinePresenter(
                             if (next.isEmpty()) SelectionState.Disabled else current.copy(selectedEventIds = next)
                         }
                         selected.size >= MAX_SELECTION_COUNT -> {
-                            snackbarDispatcher.post(SnackbarMessage(R.string.screen_room_timeline_selection_limit_reached))
+                            snackbarDispatcher.post(SnackbarMessage(CommonStrings.screen_room_maximum_messages_selected))
                             current
                         }
                         else -> current.copy(selectedEventIds = (selected + event.eventId).toPersistentSet())
diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/topbars/SelectionModeTopBar.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/topbars/SelectionModeTopBar.kt
index 1e96d7b1e1..e918c0da2b 100644
--- a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/topbars/SelectionModeTopBar.kt
+++ b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/topbars/SelectionModeTopBar.kt
@@ -23,6 +23,7 @@ import io.element.android.libraries.designsystem.theme.components.Icon
 import io.element.android.libraries.designsystem.theme.components.IconButton
 import io.element.android.libraries.designsystem.theme.components.Text
 import io.element.android.libraries.designsystem.theme.components.TopAppBar
+import io.element.android.libraries.ui.strings.CommonPlurals
 import io.element.android.libraries.ui.strings.CommonStrings
 
 @OptIn(ExperimentalMaterial3Api::class)
@@ -37,7 +38,7 @@ fun SelectionModeTopBar(
     TopAppBar(
         modifier = modifier,
         title = {
-            Text(text = pluralStringResource(R.plurals.screen_room_timeline_selection_title, selectedCount, selectedCount))
+            Text(text = pluralStringResource(CommonPlurals.common_selected_count, selectedCount, selectedCount))
         },
         navigationIcon = {
             IconButton(
diff --git a/features/messages/impl/src/main/res/values/temporary.xml b/features/messages/impl/src/main/res/values/temporary.xml
deleted file mode 100644
index 5dfeaa7b85..0000000000
--- a/features/messages/impl/src/main/res/values/temporary.xml
+++ /dev/null
@@ -1,15 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?><!--
-  ~ Copyright 2026 New Vector Ltd.
-  ~
-  ~ SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
-  ~ Please see LICENSE files in the repository root for full details.
-  -->
-
-<resources>
-    <!-- %1$d is the number of selected messages -->
-    <plurals name="screen_room_timeline_selection_title">
-        <item quantity="one">%1$d selected</item>
-        <item quantity="other">%1$d selected</item>
-    </plurals>
-    <string name="screen_room_timeline_selection_limit_reached">You can select up to 30 messages</string>
-</resources>