From 5bdaea3f6e0bb541e0b45a264728672952387124 Mon Sep 17 00:00:00 2001
From: Benoit Marty <benoit@matrix.org>
Date: Thu, 20 Aug 2026 15:20:33 +0200
Subject: [PATCH] Move FakeAccountProviderAccessControl to the login test
 module

The fake was declared in RootFlowNodeTest, so other tests could not use
it. Move it next to the API it fakes, in a package mirroring the one of
the API, and let the result be provided by the caller, so that the case
where the account provider is not allowed can be tested too.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
 .../android/appnav/RootFlowNodeTest.kt        |  8 ++------
 .../FakeAccountProviderAccessControl.kt       | 19 +++++++++++++++++++
 2 files changed, 21 insertions(+), 6 deletions(-)
 create mode 100644 features/login/test/src/main/kotlin/io/element/android/features/login/test/accesscontrol/FakeAccountProviderAccessControl.kt

diff --git a/appnav/src/test/kotlin/io/element/android/appnav/RootFlowNodeTest.kt b/appnav/src/test/kotlin/io/element/android/appnav/RootFlowNodeTest.kt
index 9cba1d7934..7562356ffd 100644
--- a/appnav/src/test/kotlin/io/element/android/appnav/RootFlowNodeTest.kt
+++ b/appnav/src/test/kotlin/io/element/android/appnav/RootFlowNodeTest.kt
@@ -32,9 +32,9 @@ import io.element.android.appnav.root.RootNavStateFlowFactory
 import io.element.android.appnav.root.RootPresenter
 import io.element.android.features.login.api.LoginEntryPoint
 import io.element.android.features.login.api.LoginParams
-import io.element.android.features.login.api.accesscontrol.AccountProviderAccessControl
 import io.element.android.features.login.test.FakeLoginEntryPoint
 import io.element.android.features.login.test.FakeLoginIntentResolver
+import io.element.android.features.login.test.accesscontrol.FakeAccountProviderAccessControl
 import io.element.android.features.preferences.test.FakeCacheService
 import io.element.android.features.rageshake.test.FakeBugReportEntryPoint
 import io.element.android.features.rageshake.test.logs.FakeAnnouncementService
@@ -150,7 +150,7 @@ class RootFlowNodeTest : RobolectricTest() {
             ),
             plugins = emptyList(),
             sessionStore = sessionStore,
-            accountProviderAccessControl = FakeAccountProviderAccessControl(),
+            accountProviderAccessControl = FakeAccountProviderAccessControl { true },
             navStateFlowFactory = RootNavStateFlowFactory(
                 sessionStore = sessionStore,
                 cacheService = FakeCacheService(),
@@ -216,10 +216,6 @@ private class FakeOAuthActionFlow : OAuthActionFlow {
     override fun reset() = Unit
 }
 
-private class FakeAccountProviderAccessControl : AccountProviderAccessControl {
-    override suspend fun isAllowedToConnectToAccountProvider(accountProviderUrl: String) = true
-}
-
 private class FakeNodeFactoriesBindings(
     private val nodeFactories: Map<KClass<out Node>, AssistedNodeFactory<*>>,
 ) : NodeFactoriesBindings {
diff --git a/features/login/test/src/main/kotlin/io/element/android/features/login/test/accesscontrol/FakeAccountProviderAccessControl.kt b/features/login/test/src/main/kotlin/io/element/android/features/login/test/accesscontrol/FakeAccountProviderAccessControl.kt
new file mode 100644
index 0000000000..9ebd3be7fc
--- /dev/null
+++ b/features/login/test/src/main/kotlin/io/element/android/features/login/test/accesscontrol/FakeAccountProviderAccessControl.kt
@@ -0,0 +1,19 @@
+/*
+ * Copyright (c) 2026 Element Creations Ltd.
+ *
+ * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
+ * Please see LICENSE files in the repository root for full details.
+ */
+
+package io.element.android.features.login.test.accesscontrol
+
+import io.element.android.features.login.api.accesscontrol.AccountProviderAccessControl
+import io.element.android.tests.testutils.lambda.lambdaError
+
+class FakeAccountProviderAccessControl(
+    private val isAllowedToConnectToAccountProviderResult: (String) -> Boolean = { lambdaError() },
+) : AccountProviderAccessControl {
+    override suspend fun isAllowedToConnectToAccountProvider(accountProviderUrl: String): Boolean {
+        return isAllowedToConnectToAccountProviderResult(accountProviderUrl)
+    }
+}