ehealthsolutions/element-x-android
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-android.git synced 2026-11-03 06:55:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

a11y: improve content description of the close formatting button. Change from "Close" to "Cancel and close text formatting"

Browse Source
This commit is contained in:
Benoit Marty
2025-06-26 15:55:15 +02:00
parent 871fb88018
commit 3b687a129c
2 changed files with 14 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/textcomposer/impl/src/main/kotlin/io/element/android/libraries/textcomposer/TextComposer.kt
+5 -3
View File
@@ -178,7 +178,8 @@ fun TextComposer(
remember(state.richTextEditorState, composerMode, onResetComposerMode, onError) { remember(state.richTextEditorState, composerMode, onResetComposerMode, onError) {
@Composable { @Composable {
TextInputBox( TextInputBox(
modifier = Modifier.clickable( modifier = Modifier
.clickable(
interactionSource = remember { MutableInteractionSource() }, interactionSource = remember { MutableInteractionSource() },
indication = null, indication = null,
) { ) {
@@ -186,7 +187,8 @@ fun TextComposer(
state.requestFocus() state.requestFocus()
view.showKeyboard() view.showKeyboard()
} }
}.semantics { }
.semantics {
hideFromAccessibility() hideFromAccessibility()
}, },
composerMode = composerMode, composerMode = composerMode,
@@ -317,7 +319,7 @@ fun TextComposer(
IconColorButton( IconColorButton(
onClick = onDismissTextFormatting, onClick = onDismissTextFormatting,
imageVector = CompoundIcons.Close(), imageVector = CompoundIcons.Close(),
contentDescription = stringResource(CommonStrings.action_close), contentDescription = stringResource(R.string.rich_text_editor_close_formatting_options),
) )
}, },
textFormatting = textFormattingOptions, textFormatting = textFormattingOptions,
libraries/textcomposer/impl/src/main/res/values/localazy.xml
+1 -1
View File
@@ -2,7 +2,7 @@
<resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2"> <resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
<string name="rich_text_editor_a11y_add_attachment">"Add attachment"</string> <string name="rich_text_editor_a11y_add_attachment">"Add attachment"</string>
<string name="rich_text_editor_bullet_list">"Toggle bullet list"</string> <string name="rich_text_editor_bullet_list">"Toggle bullet list"</string>
<string name="rich_text_editor_close_formatting_options">"Close formatting options"</string> <string name="rich_text_editor_close_formatting_options">"Cancel and close text formatting"</string>
<string name="rich_text_editor_code_block">"Toggle code block"</string> <string name="rich_text_editor_code_block">"Toggle code block"</string>
<string name="rich_text_editor_composer_caption_placeholder">"Add a caption"</string> <string name="rich_text_editor_composer_caption_placeholder">"Add a caption"</string>
<string name="rich_text_editor_composer_encrypted_placeholder">"Encrypted message…"</string> <string name="rich_text_editor_composer_encrypted_placeholder">"Encrypted message…"</string>