mirror of
https://github.com/Novaloop-AG/element-x-android.git
synced 2026-11-03 06:55:41 +00:00
Merge pull request #7387 from element-hq/feature/bma/complementFor7376
Update in reply to message when message is not found.
This commit is contained in:
+1
-1
@@ -812,7 +812,7 @@ private fun MessageEventBubbleContent(
|
|||||||
else -> inReplyToModifier.clickable(onClick = inReplyToClick)
|
else -> inReplyToModifier.clickable(onClick = inReplyToClick)
|
||||||
}
|
}
|
||||||
|
|
||||||
val contentHasError = currentContentValidationState.hasError()
|
val contentHasError = currentContentValidationState.hasError() || inReplyTo is InReplyToDetails.Error
|
||||||
val borderColor = if (contentHasError) ElementTheme.colors.borderCriticalSubtle else ElementTheme.colors.separatorPrimary
|
val borderColor = if (contentHasError) ElementTheme.colors.borderCriticalSubtle else ElementTheme.colors.separatorPrimary
|
||||||
val backgroundColor = if (contentHasError) ElementTheme.colors.bgCriticalSubtle else ElementTheme.colors.bgCanvasDefault
|
val backgroundColor = if (contentHasError) ElementTheme.colors.bgCriticalSubtle else ElementTheme.colors.bgCanvasDefault
|
||||||
Box(
|
Box(
|
||||||
|
|||||||
+9
-7
@@ -27,7 +27,7 @@ import io.element.android.compound.tokens.generated.CompoundIcons
|
|||||||
@Composable
|
@Composable
|
||||||
internal fun ContentErrorView(
|
internal fun ContentErrorView(
|
||||||
title: String,
|
title: String,
|
||||||
message: String,
|
message: String?,
|
||||||
modifier: Modifier = Modifier,
|
modifier: Modifier = Modifier,
|
||||||
contentPadding: PaddingValues = PaddingValues.Zero,
|
contentPadding: PaddingValues = PaddingValues.Zero,
|
||||||
onTextLayout: ((TextLayoutResult) -> Unit)? = null,
|
onTextLayout: ((TextLayoutResult) -> Unit)? = null,
|
||||||
@@ -51,12 +51,14 @@ internal fun ContentErrorView(
|
|||||||
color = ElementTheme.colors.textCriticalPrimary,
|
color = ElementTheme.colors.textCriticalPrimary,
|
||||||
style = ElementTheme.typography.fontBodyMdMedium,
|
style = ElementTheme.typography.fontBodyMdMedium,
|
||||||
)
|
)
|
||||||
Text(
|
if (message != null) {
|
||||||
text = message,
|
Text(
|
||||||
color = ElementTheme.colors.textSecondary,
|
text = message,
|
||||||
style = ElementTheme.typography.fontBodySmRegular,
|
color = ElementTheme.colors.textSecondary,
|
||||||
onTextLayout = onTextLayout,
|
style = ElementTheme.typography.fontBodySmRegular,
|
||||||
)
|
onTextLayout = onTextLayout,
|
||||||
|
)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
+9
-18
@@ -19,7 +19,6 @@ import androidx.compose.foundation.layout.size
|
|||||||
import androidx.compose.foundation.layout.width
|
import androidx.compose.foundation.layout.width
|
||||||
import androidx.compose.foundation.shape.RoundedCornerShape
|
import androidx.compose.foundation.shape.RoundedCornerShape
|
||||||
import androidx.compose.runtime.Composable
|
import androidx.compose.runtime.Composable
|
||||||
import androidx.compose.runtime.getValue
|
|
||||||
import androidx.compose.ui.Alignment
|
import androidx.compose.ui.Alignment
|
||||||
import androidx.compose.ui.Modifier
|
import androidx.compose.ui.Modifier
|
||||||
import androidx.compose.ui.draw.clip
|
import androidx.compose.ui.draw.clip
|
||||||
@@ -45,6 +44,7 @@ import io.element.android.libraries.matrix.api.core.UserId
|
|||||||
import io.element.android.libraries.matrix.api.timeline.item.event.ProfileDetails
|
import io.element.android.libraries.matrix.api.timeline.item.event.ProfileDetails
|
||||||
import io.element.android.libraries.matrix.api.timeline.item.event.getDisambiguatedDisplayName
|
import io.element.android.libraries.matrix.api.timeline.item.event.getDisambiguatedDisplayName
|
||||||
import io.element.android.libraries.matrix.ui.components.AttachmentThumbnail
|
import io.element.android.libraries.matrix.ui.components.AttachmentThumbnail
|
||||||
|
import io.element.android.libraries.matrix.ui.media.contentvalidation.ContentErrorView
|
||||||
import io.element.android.libraries.matrix.ui.media.contentvalidation.ContentValidationValue
|
import io.element.android.libraries.matrix.ui.media.contentvalidation.ContentValidationValue
|
||||||
import io.element.android.libraries.matrix.ui.media.contentvalidation.InvalidContentView
|
import io.element.android.libraries.matrix.ui.media.contentvalidation.InvalidContentView
|
||||||
import io.element.android.libraries.matrix.ui.media.contentvalidation.NotFoundContentView
|
import io.element.android.libraries.matrix.ui.media.contentvalidation.NotFoundContentView
|
||||||
@@ -77,7 +77,7 @@ fun InReplyToView(
|
|||||||
else -> ReplyToLoadingContent(modifier = modifier)
|
else -> ReplyToLoadingContent(modifier = modifier)
|
||||||
}
|
}
|
||||||
is InReplyToDetails.Error ->
|
is InReplyToDetails.Error ->
|
||||||
ReplyToErrorContent(maxLines = maxLines, modifier = modifier)
|
ReplyToErrorContent(modifier = modifier)
|
||||||
is InReplyToDetails.Loading ->
|
is InReplyToDetails.Loading ->
|
||||||
ReplyToLoadingContent(modifier = modifier)
|
ReplyToLoadingContent(modifier = modifier)
|
||||||
}
|
}
|
||||||
@@ -150,24 +150,15 @@ private fun ReplyToLoadingContent(
|
|||||||
|
|
||||||
@Composable
|
@Composable
|
||||||
private fun ReplyToErrorContent(
|
private fun ReplyToErrorContent(
|
||||||
maxLines: Int,
|
|
||||||
modifier: Modifier = Modifier,
|
modifier: Modifier = Modifier,
|
||||||
) {
|
) {
|
||||||
val paddings = PaddingValues(horizontal = 12.dp, vertical = 4.dp)
|
ContentErrorView(
|
||||||
Row(
|
title = stringResource(CommonStrings.error_message_not_found),
|
||||||
modifier
|
message = null,
|
||||||
.background(ElementTheme.colors.bgCanvasDefault)
|
modifier = modifier,
|
||||||
.padding(paddings)
|
contentPadding = PaddingValues(vertical = 4.dp, horizontal = 8.dp),
|
||||||
) {
|
onTextLayout = null,
|
||||||
Text(
|
)
|
||||||
text = stringResource(id = CommonStrings.error_message_not_found),
|
|
||||||
style = ElementTheme.typography.fontBodyMdRegular,
|
|
||||||
fontStyle = FontStyle.Italic,
|
|
||||||
color = ElementTheme.colors.textSecondary,
|
|
||||||
maxLines = maxLines,
|
|
||||||
overflow = TextOverflow.Ellipsis,
|
|
||||||
)
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
@Composable
|
@Composable
|
||||||
|
|||||||
BIN
Binary file not shown.
Reference in New Issue
Block a user