Make PushData.clientSecret mandatory.

Also do not restore the last session as a fallback, it can lead to error in a multi account context, or even when a ghost pusher send a Push.

libraries/pushproviders/firebase/src/main/kotlin/io/element/android/libraries/pushproviders/firebase/PushDataFirebase.kt

@@ -34,10 +34,11 @@ data class PushDataFirebase(
 fun PushDataFirebase.toPushData(): PushData? {
     val safeEventId = eventId?.let(::EventId) ?: return null
     val safeRoomId = roomId?.let(::RoomId) ?: return null
+    val safeClientSecret = clientSecret ?: return null
     return PushData(
         eventId = safeEventId,
         roomId = safeRoomId,
         unread = unread,
-        clientSecret = clientSecret,
+        clientSecret = safeClientSecret,
     )
 }

libraries/pushproviders/firebase/src/test/kotlin/io/element/android/libraries/pushproviders/firebase/FirebasePushParserTest.kt

@@ -59,6 +59,12 @@ class FirebasePushParserTest {
         assertThrowsInDebug { pushParser.parse(FIREBASE_PUSH_DATA.mutate("event_id", "")) }
     }
 
+    @Test
+    fun `test empty client secret`() {
+        val pushParser = FirebasePushParser()
+        assertThat(pushParser.parse(FIREBASE_PUSH_DATA.mutate("cs", null))).isNull()
+    }
+
     @Test
     fun `test invalid eventId`() {
         val pushParser = FirebasePushParser()