mirror of
https://github.com/Novaloop-AG/element-x-android.git
synced 2026-11-03 06:55:41 +00:00
ForwardMessagesEvents -> ForwardMessagesEvent
This commit is contained in:
+2
-2
@@ -8,6 +8,6 @@
|
|||||||
|
|
||||||
package io.element.android.features.forward.impl
|
package io.element.android.features.forward.impl
|
||||||
|
|
||||||
sealed interface ForwardMessagesEvents {
|
sealed interface ForwardMessagesEvent {
|
||||||
data object ClearError : ForwardMessagesEvents
|
data object ClearError : ForwardMessagesEvent
|
||||||
}
|
}
|
||||||
+2
-2
@@ -48,9 +48,9 @@ class ForwardMessagesPresenter(
|
|||||||
|
|
||||||
@Composable
|
@Composable
|
||||||
override fun present(): ForwardMessagesState {
|
override fun present(): ForwardMessagesState {
|
||||||
fun handleEvent(event: ForwardMessagesEvents) {
|
fun handleEvent(event: ForwardMessagesEvent) {
|
||||||
when (event) {
|
when (event) {
|
||||||
ForwardMessagesEvents.ClearError -> forwardingActionState.value = AsyncAction.Uninitialized
|
ForwardMessagesEvent.ClearError -> forwardingActionState.value = AsyncAction.Uninitialized
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
+1
-1
@@ -13,5 +13,5 @@ import io.element.android.libraries.matrix.api.core.RoomId
|
|||||||
|
|
||||||
data class ForwardMessagesState(
|
data class ForwardMessagesState(
|
||||||
val forwardAction: AsyncAction<List<RoomId>>,
|
val forwardAction: AsyncAction<List<RoomId>>,
|
||||||
val eventSink: (ForwardMessagesEvents) -> Unit
|
val eventSink: (ForwardMessagesEvent) -> Unit
|
||||||
)
|
)
|
||||||
|
|||||||
+1
-1
@@ -32,7 +32,7 @@ open class ForwardMessagesStatePreviewParam : PreviewParameterProvider<ForwardMe
|
|||||||
|
|
||||||
fun aForwardMessagesState(
|
fun aForwardMessagesState(
|
||||||
forwardAction: AsyncAction<List<RoomId>> = AsyncAction.Uninitialized,
|
forwardAction: AsyncAction<List<RoomId>> = AsyncAction.Uninitialized,
|
||||||
eventSink: (ForwardMessagesEvents) -> Unit = {}
|
eventSink: (ForwardMessagesEvent) -> Unit = {}
|
||||||
) = ForwardMessagesState(
|
) = ForwardMessagesState(
|
||||||
forwardAction = forwardAction,
|
forwardAction = forwardAction,
|
||||||
eventSink = eventSink
|
eventSink = eventSink
|
||||||
|
|||||||
+1
-1
@@ -31,7 +31,7 @@ fun ForwardMessagesView(
|
|||||||
stringResource(id = CommonStrings.error_unknown)
|
stringResource(id = CommonStrings.error_unknown)
|
||||||
},
|
},
|
||||||
onErrorDismiss = {
|
onErrorDismiss = {
|
||||||
state.eventSink(ForwardMessagesEvents.ClearError)
|
state.eventSink(ForwardMessagesEvent.ClearError)
|
||||||
},
|
},
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|||||||
+1
-1
@@ -86,7 +86,7 @@ class ForwardMessagesPresenterTest {
|
|||||||
val failedForwardState = awaitItem()
|
val failedForwardState = awaitItem()
|
||||||
assertThat(failedForwardState.forwardAction.isFailure()).isTrue()
|
assertThat(failedForwardState.forwardAction.isFailure()).isTrue()
|
||||||
// Then clear error
|
// Then clear error
|
||||||
failedForwardState.eventSink(ForwardMessagesEvents.ClearError)
|
failedForwardState.eventSink(ForwardMessagesEvent.ClearError)
|
||||||
assertThat(awaitItem().forwardAction.isUninitialized()).isTrue()
|
assertThat(awaitItem().forwardAction.isUninitialized()).isTrue()
|
||||||
forwardEventLambda.assertions().isCalledOnce()
|
forwardEventLambda.assertions().isCalledOnce()
|
||||||
}
|
}
|
||||||
|
|||||||
+3
-3
@@ -29,7 +29,7 @@ import org.junit.Test
|
|||||||
class ForwardMessagesViewTest : RobolectricTest() {
|
class ForwardMessagesViewTest : RobolectricTest() {
|
||||||
@Test
|
@Test
|
||||||
fun `cancel error emits the expected event`() = runAndroidComposeUiTest {
|
fun `cancel error emits the expected event`() = runAndroidComposeUiTest {
|
||||||
val eventsRecorder = EventsRecorder<ForwardMessagesEvents>()
|
val eventsRecorder = EventsRecorder<ForwardMessagesEvent>()
|
||||||
setForwardMessagesView(
|
setForwardMessagesView(
|
||||||
aForwardMessagesState(
|
aForwardMessagesState(
|
||||||
forwardAction = AsyncAction.Failure(AN_EXCEPTION),
|
forwardAction = AsyncAction.Failure(AN_EXCEPTION),
|
||||||
@@ -37,13 +37,13 @@ class ForwardMessagesViewTest : RobolectricTest() {
|
|||||||
),
|
),
|
||||||
)
|
)
|
||||||
pressTag(TestTags.dialogPositive.value)
|
pressTag(TestTags.dialogPositive.value)
|
||||||
eventsRecorder.assertSingle(ForwardMessagesEvents.ClearError)
|
eventsRecorder.assertSingle(ForwardMessagesEvent.ClearError)
|
||||||
}
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
fun `success invokes onForwardSuccess`() = runAndroidComposeUiTest {
|
fun `success invokes onForwardSuccess`() = runAndroidComposeUiTest {
|
||||||
val data = listOf(A_ROOM_ID)
|
val data = listOf(A_ROOM_ID)
|
||||||
val eventsRecorder = EventsRecorder<ForwardMessagesEvents>(expectEvents = false)
|
val eventsRecorder = EventsRecorder<ForwardMessagesEvent>(expectEvents = false)
|
||||||
ensureCalledOnceWithParam<List<RoomId>?>(data) { callback ->
|
ensureCalledOnceWithParam<List<RoomId>?>(data) { callback ->
|
||||||
setForwardMessagesView(
|
setForwardMessagesView(
|
||||||
aForwardMessagesState(
|
aForwardMessagesState(
|
||||||
|
|||||||
Reference in New Issue
Block a user