ehealthsolutions/element-x-android
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-android.git synced 2026-11-02 21:05:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

RoomAliasResolverEvents -> RoomAliasResolverEvent

Browse Source
This commit is contained in:
Benoit Marty
2026-08-25 10:16:32 +02:00
parent 4e2d99c968
commit 15569ef3e8
7 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
features/roomaliasresolver/impl/src/main/kotlin/io/element/android/features/roomaliasresolver/impl/RoomAliasResolverEvents.kt → features/roomaliasresolver/impl/src/main/kotlin/io/element/android/features/roomaliasresolver/impl/RoomAliasResolverEvent.kt
+3 -3
View File
@@ -8,7 +8,7 @@
package io.element.android.features.roomaliasresolver.impl
sealed interface RoomAliasResolverEvents {
data object Retry : RoomAliasResolverEvents
data object DismissError : RoomAliasResolverEvents
sealed interface RoomAliasResolverEvent {
data object Retry : RoomAliasResolverEvent
data object DismissError : RoomAliasResolverEvent
}
features/roomaliasresolver/impl/src/main/kotlin/io/element/android/features/roomaliasresolver/impl/RoomAliasResolverPresenter.kt
+3 -3
View File
@@ -48,10 +48,10 @@ class RoomAliasResolverPresenter(
resolveAlias(resolveState)
}
fun handleEvent(event: RoomAliasResolverEvents) {
fun handleEvent(event: RoomAliasResolverEvent) {
when (event) {
RoomAliasResolverEvents.Retry -> coroutineScope.resolveAlias(resolveState)
RoomAliasResolverEvents.DismissError -> resolveState.value = AsyncData.Uninitialized
RoomAliasResolverEvent.Retry -> coroutineScope.resolveAlias(resolveState)
RoomAliasResolverEvent.DismissError -> resolveState.value = AsyncData.Uninitialized
}
}
features/roomaliasresolver/impl/src/main/kotlin/io/element/android/features/roomaliasresolver/impl/RoomAliasResolverState.kt
+1 -1
View File
@@ -15,7 +15,7 @@ import io.element.android.libraries.matrix.api.room.alias.ResolvedRoomAlias
data class RoomAliasResolverState(
val roomAlias: RoomAlias,
val resolveState: AsyncData<ResolvedRoomAlias>,
val eventSink: (RoomAliasResolverEvents) -> Unit
val eventSink: (RoomAliasResolverEvent) -> Unit
)
sealed class RoomAliasResolverFailures : Exception() {
features/roomaliasresolver/impl/src/main/kotlin/io/element/android/features/roomaliasresolver/impl/RoomAliasResolverStatePreviewParam.kt
+1 -1
View File
@@ -30,7 +30,7 @@ open class RoomAliasResolverStatePreviewParam : PreviewParameterProvider<RoomAli
fun aRoomAliasResolverState(
roomAlias: RoomAlias = A_ROOM_ALIAS,
resolveState: AsyncData<ResolvedRoomAlias> = AsyncData.Uninitialized,
eventSink: (RoomAliasResolverEvents) -> Unit = {}
eventSink: (RoomAliasResolverEvent) -> Unit = {}
) = RoomAliasResolverState(
roomAlias = roomAlias,
resolveState = resolveState,
features/roomaliasresolver/impl/src/main/kotlin/io/element/android/features/roomaliasresolver/impl/RoomAliasResolverView.kt
+2 -2
View File
@@ -66,9 +66,9 @@ fun RoomAliasResolverView(
ResolvedRoomAliasView(
resolvedRoomAlias = state.resolveState,
onSuccess = onSuccess,
onRetry = { state.eventSink(RoomAliasResolverEvents.Retry) },
onRetry = { state.eventSink(RoomAliasResolverEvent.Retry) },
onDismissError = {
state.eventSink(RoomAliasResolverEvents.DismissError)
state.eventSink(RoomAliasResolverEvent.DismissError)
onBackClick()
}
)
features/roomaliasresolver/impl/src/test/kotlin/io/element/android/features/roomaliasresolver/impl/RoomAliasHelperPresenterTest.kt
+1 -1
View File
@@ -91,7 +91,7 @@ class RoomAliasHelperPresenterTest {
assertThat(awaitItem().resolveState.isLoading()).isTrue()
val resultState = awaitItem()
assertThat(resultState.resolveState.errorOrNull()).isEqualTo(AN_EXCEPTION)
resultState.eventSink(RoomAliasResolverEvents.Retry)
resultState.eventSink(RoomAliasResolverEvent.Retry)
val retryLoadingState = awaitItem()
assertThat(retryLoadingState.resolveState.isLoading()).isTrue()
val retryState = awaitItem()
features/roomaliasresolver/impl/src/test/kotlin/io/element/android/features/roomaliasresolver/impl/RoomAliasHelperViewTest.kt
+4 -4
View File
@@ -30,7 +30,7 @@ import org.junit.Test
class RoomAliasHelperViewTest : RobolectricTest() {
@Test
fun `clicking on back invokes the expected callback`() = runAndroidComposeUiTest {
val eventsRecorder = EventsRecorder<RoomAliasResolverEvents>(expectEvents = false)
val eventsRecorder = EventsRecorder<RoomAliasResolverEvent>(expectEvents = false)
ensureCalledOnce {
setRoomAliasResolverView(
aRoomAliasResolverState(
@@ -44,7 +44,7 @@ class RoomAliasHelperViewTest : RobolectricTest() {
@Test
fun `clicking on Retry emits the expected Event`() = runAndroidComposeUiTest {
val eventsRecorder = EventsRecorder<RoomAliasResolverEvents>()
val eventsRecorder = EventsRecorder<RoomAliasResolverEvent>()
setRoomAliasResolverView(
aRoomAliasResolverState(
resolveState = AsyncData.Failure(Exception("Error")),
@@ -52,13 +52,13 @@ class RoomAliasHelperViewTest : RobolectricTest() {
),
)
clickOn(CommonStrings.action_retry)
eventsRecorder.assertSingle(RoomAliasResolverEvents.Retry)
eventsRecorder.assertSingle(RoomAliasResolverEvent.Retry)
}
@Test
fun `success state invokes the expected Callback`() = runAndroidComposeUiTest {
val result = aResolvedRoomAlias()
val eventsRecorder = EventsRecorder<RoomAliasResolverEvents>(expectEvents = false)
val eventsRecorder = EventsRecorder<RoomAliasResolverEvent>(expectEvents = false)
ensureCalledOnceWithParam(result) {
setRoomAliasResolverView(
aRoomAliasResolverState(