ehealthsolutions/element-x-android
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-android.git synced 2026-11-02 21:32:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix lint issue, ensure that PiP methods are not called on old devices not supporting them.

Browse Source
This commit is contained in:
Benoit Marty
2026-08-24 12:52:39 +02:00
parent 16954bb66e
commit 0d3d8c8456
3 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
features/call/impl/src/main/kotlin/io/element/android/features/call/impl/pip/PictureInPicturePresenter.kt
+3 -1
View File
@@ -60,7 +60,9 @@ class PictureInPicturePresenter(
} }
is PictureInPictureEvent.SetPipOrientation -> { is PictureInPictureEvent.SetPipOrientation -> {
Timber.tag(loggerTag.value).d("onOrientationChange: ${event.orientation}") Timber.tag(loggerTag.value).d("onOrientationChange: ${event.orientation}")
pipView?.setPipOrientation(event.orientation) if (isPipSupported) {
pipView?.setPipOrientation(event.orientation)
}
} }
} }
} }
features/call/impl/src/main/kotlin/io/element/android/features/call/impl/pip/PipView.kt
+6
View File
@@ -8,9 +8,15 @@
package io.element.android.features.call.impl.pip package io.element.android.features.call.impl.pip
import android.os.Build
import androidx.annotation.RequiresApi
interface PipView { interface PipView {
@RequiresApi(Build.VERSION_CODES.O)
fun setPipOrientation(orientation: Int?) fun setPipOrientation(orientation: Int?)
@RequiresApi(Build.VERSION_CODES.O)
fun setPipParams() fun setPipParams()
@RequiresApi(Build.VERSION_CODES.O)
fun enterPipMode(): Boolean fun enterPipMode(): Boolean
fun hangUp() fun hangUp()
} }
features/call/impl/src/main/kotlin/io/element/android/features/call/impl/ui/ElementCallActivity.kt
+4 -1
View File
@@ -202,7 +202,9 @@ class ElementCallActivity :
} }
DisposableEffect(Unit) { DisposableEffect(Unit) {
val onPictureInPictureModeChangedListener = Consumer { _: PictureInPictureModeChangedInfo -> val onPictureInPictureModeChangedListener = Consumer { _: PictureInPictureModeChangedInfo ->
setPipParams() if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
setPipParams()
}
pipEventSink(PictureInPictureEvent.OnPictureInPictureModeChanged(isInPictureInPictureMode)) pipEventSink(PictureInPictureEvent.OnPictureInPictureModeChanged(isInPictureInPictureMode))
if (!isInPictureInPictureMode && !lifecycle.currentState.isAtLeast(Lifecycle.State.STARTED)) { if (!isInPictureInPictureMode && !lifecycle.currentState.isAtLeast(Lifecycle.State.STARTED)) {
Timber.tag(loggerTag.value).d("Exiting PiP mode: Hangup the call") Timber.tag(loggerTag.value).d("Exiting PiP mode: Hangup the call")
@@ -300,6 +302,7 @@ class ElementCallActivity :
} }
} }
@RequiresApi(Build.VERSION_CODES.O)
override fun setPipOrientation(orientation: Int?) { override fun setPipOrientation(orientation: Int?) {
currentPipOrientation = orientation currentPipOrientation = orientation
setPictureInPictureParams(getPictureInPictureParams()) setPictureInPictureParams(getPictureInPictureParams())