From 07983221e69da67885c0fbe394130f22aaaf6744 Mon Sep 17 00:00:00 2001
From: Benoit Marty <benoit@matrix.org>
Date: Tue, 18 Aug 2026 16:25:57 +0200
Subject: [PATCH] Move google_app_id to resource files.

---
 .../pushproviders/firebase/build.gradle.kts    | 18 ------------------
 .../firebase/src/debug/res/values/firebase.xml |  4 ++++
 .../src/nightly/res/values/firebase.xml        |  4 ++++
 .../src/release/res/values/firebase.xml        |  4 ++++
 .../src/main/kotlin/config/BuildTimeConfig.kt  |  3 ---
 5 files changed, 12 insertions(+), 21 deletions(-)
 create mode 100644 libraries/pushproviders/firebase/src/debug/res/values/firebase.xml
 create mode 100644 libraries/pushproviders/firebase/src/nightly/res/values/firebase.xml
 create mode 100644 libraries/pushproviders/firebase/src/release/res/values/firebase.xml

diff --git a/libraries/pushproviders/firebase/build.gradle.kts b/libraries/pushproviders/firebase/build.gradle.kts
index 1a8e73a4da..33e88dd94c 100644
--- a/libraries/pushproviders/firebase/build.gradle.kts
+++ b/libraries/pushproviders/firebase/build.gradle.kts
@@ -8,7 +8,6 @@
 
 @file:Suppress("UnstableApiUsage")
 
-import config.BuildTimeConfig
 import extension.setupDependencyInjection
 import extension.testCommonDependencies
 import org.gradle.kotlin.dsl.withType
@@ -28,27 +27,10 @@ android {
     buildTypes {
         getByName("release") {
             consumerProguardFiles("consumer-proguard-rules.pro")
-            resValue(
-                type = "string",
-                name = "google_app_id",
-                value = BuildTimeConfig.GOOGLE_APP_ID_RELEASE,
-            )
-        }
-        getByName("debug") {
-            resValue(
-                type = "string",
-                name = "google_app_id",
-                value = BuildTimeConfig.GOOGLE_APP_ID_DEBUG,
-            )
         }
         register("nightly") {
             consumerProguardFiles("consumer-proguard-rules.pro")
             matchingFallbacks += listOf("release")
-            resValue(
-                type = "string",
-                name = "google_app_id",
-                value = BuildTimeConfig.GOOGLE_APP_ID_NIGHTLY,
-            )
         }
     }
 }
diff --git a/libraries/pushproviders/firebase/src/debug/res/values/firebase.xml b/libraries/pushproviders/firebase/src/debug/res/values/firebase.xml
new file mode 100644
index 0000000000..e96f163603
--- /dev/null
+++ b/libraries/pushproviders/firebase/src/debug/res/values/firebase.xml
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources xmlns:tools="http://schemas.android.com/tools">
+    <string name="google_app_id" translatable="false" tools:ignore="UnusedResources">1:912726360885:android:def0a4e454042e9b00427c</string>
+</resources>
diff --git a/libraries/pushproviders/firebase/src/nightly/res/values/firebase.xml b/libraries/pushproviders/firebase/src/nightly/res/values/firebase.xml
new file mode 100644
index 0000000000..7275ff2ddd
--- /dev/null
+++ b/libraries/pushproviders/firebase/src/nightly/res/values/firebase.xml
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources xmlns:tools="http://schemas.android.com/tools">
+    <string name="google_app_id" translatable="false" tools:ignore="UnusedResources">1:912726360885:android:e17435e0beb0303000427c</string>
+</resources>
diff --git a/libraries/pushproviders/firebase/src/release/res/values/firebase.xml b/libraries/pushproviders/firebase/src/release/res/values/firebase.xml
new file mode 100644
index 0000000000..3a9a4330d1
--- /dev/null
+++ b/libraries/pushproviders/firebase/src/release/res/values/firebase.xml
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources xmlns:tools="http://schemas.android.com/tools">
+    <string name="google_app_id" translatable="false" tools:ignore="UnusedResources">1:912726360885:android:d097de99a4c23d2700427c</string>
+</resources>
diff --git a/plugins/src/main/kotlin/config/BuildTimeConfig.kt b/plugins/src/main/kotlin/config/BuildTimeConfig.kt
index ffad44fdc5..e31ffea658 100644
--- a/plugins/src/main/kotlin/config/BuildTimeConfig.kt
+++ b/plugins/src/main/kotlin/config/BuildTimeConfig.kt
@@ -11,9 +11,6 @@ package config
 object BuildTimeConfig {
     const val APPLICATION_ID = "io.element.android.x"
     const val APPLICATION_NAME = "Element X"
-    const val GOOGLE_APP_ID_RELEASE = "1:912726360885:android:d097de99a4c23d2700427c"
-    const val GOOGLE_APP_ID_DEBUG = "1:912726360885:android:def0a4e454042e9b00427c"
-    const val GOOGLE_APP_ID_NIGHTLY = "1:912726360885:android:e17435e0beb0303000427c"
     val METADATA_HOST_REVERSED: String? = null
     val OAUTH_CLIENT_URL_PATH: String? = "apps/android"
     val URL_WEBSITE: String? = null