Remove NodeBuilder to ensure that Params and Callback are always provided.

features/roomaliasresolver/impl/src/main/kotlin/io/element/android/features/roomaliasresolver/impl/DefaultRoomAliasResolverEntryPoint.kt

@@ -9,7 +9,6 @@ package io.element.android.features.roomaliasresolver.impl
 
 import com.bumble.appyx.core.modality.BuildContext
 import com.bumble.appyx.core.node.Node
-import com.bumble.appyx.core.plugin.Plugin
 import dev.zacsweers.metro.AppScope
 import dev.zacsweers.metro.ContributesBinding
 import io.element.android.features.roomaliasesolver.api.RoomAliasResolverEntryPoint
@@ -17,23 +16,15 @@ import io.element.android.libraries.architecture.createNode
 
 @ContributesBinding(AppScope::class)
 class DefaultRoomAliasResolverEntryPoint : RoomAliasResolverEntryPoint {
-    override fun nodeBuilder(parentNode: Node, buildContext: BuildContext): RoomAliasResolverEntryPoint.NodeBuilder {
-        val plugins = ArrayList<Plugin>()
-
-        return object : RoomAliasResolverEntryPoint.NodeBuilder {
-            override fun callback(callback: RoomAliasResolverEntryPoint.Callback): RoomAliasResolverEntryPoint.NodeBuilder {
-                plugins += callback
-                return this
-            }
-
-            override fun params(params: RoomAliasResolverEntryPoint.Params): RoomAliasResolverEntryPoint.NodeBuilder {
-                plugins += params
-                return this
-            }
-
-            override fun build(): Node {
-                return parentNode.createNode<RoomAliasResolverNode>(buildContext, plugins)
-            }
-        }
+    override fun createNode(
+        parentNode: Node,
+        buildContext: BuildContext,
+        params: RoomAliasResolverEntryPoint.Params,
+        callback: RoomAliasResolverEntryPoint.Callback,
+    ): Node {
+        return parentNode.createNode<RoomAliasResolverNode>(
+            buildContext = buildContext,
+            plugins = listOf(params, callback),
+        )
     }
 }

features/roomaliasresolver/impl/src/test/kotlin/io/element/android/features/roomaliasresolver/impl/DefaultRoomAliasResolverEntryPointTest.kt

@@ -43,10 +43,12 @@ class DefaultRoomAliasResolverEntryPointTest {
         val params = RoomAliasResolverEntryPoint.Params(
             roomAlias = A_ROOM_ALIAS
         )
-        val result = entryPoint.nodeBuilder(parentNode, BuildContext.root(null))
-            .params(params)
-            .callback(callback)
-            .build()
+        val result = entryPoint.createNode(
+            parentNode = parentNode,
+            buildContext = BuildContext.root(null),
+            params = params,
+            callback = callback,
+        )
         assertThat(result).isInstanceOf(RoomAliasResolverNode::class.java)
         assertThat(result.plugins).contains(params)
         assertThat(result.plugins).contains(callback)